linux-kernel - Re: [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <251054e3-f80c-4feb-bb07-b581d7433933@kernel.org>
Date: Fri, 29 Nov 2024 17:05:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ciprian Costea <ciprianmarian.costea@....nxp.com>,
 Marc Kleine-Budde <mkl@...gutronix.de>,
 Vincent Mailhol <mailhol.vincent@...adoo.fr>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-can@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, NXP S32 Linux <s32@....com>,
 imx@...ts.linux.dev, Christophe Lizzi <clizzi@...hat.com>,
 Alberto Ruiz <aruizrui@...hat.com>, Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC
 support

On 29/11/2024 15:25, Ciprian Costea wrote:
> +      properties:
> +        interrupts:
> +          items:
> +            - description: Message Buffer interrupt for mailboxes 0-7 and Enhanced RX FIFO
> +            - description: Device state change
> +            - description: Error detection
> +            - description: Message Buffer interrupt for mailboxes 8-127
> +        interrupt-names:
> +          items:
> +            - const: mb-0
> +            - const: state
> +            - const: berr
> +            - const: mb-1
> +      required:
> +        - compatible
> +        - reg


Drop, aren't they already required?

> +        - interrupts
> +        - interrupt-names
> +    else:
> +      properties:
> +        interrupts:
> +          maxItems: 1


Missing constraints for interrupt-names, e.g. :false.


> +
>  additionalProperties: false
>  
>  examples:


Best regards,
Krzysztof