linux-kernel - Re: [PATCH RESEND v7 11/17] soc: qcom: ice: add support for generating, importing and preparing keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412030742.vCplCxJb-lkp@intel.com>
Date: Tue, 3 Dec 2024 08:11:03 +0800
From: kernel test robot <lkp@...el.com>
To: Bartosz Golaszewski <brgl@...ev.pl>, Jens Axboe <axboe@...nel.dk>,
	Jonathan Corbet <corbet@....net>, Alasdair Kergon <agk@...hat.com>,
	Mike Snitzer <snitzer@...nel.org>,
	Mikulas Patocka <mpatocka@...hat.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Asutosh Das <quic_asutoshd@...cinc.com>,
	Ritesh Harjani <ritesh.list@...il.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Avri Altman <avri.altman@....com>,
	Bart Van Assche <bvanassche@....org>,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	Gaurav Kashyap <quic_gaurkash@...cinc.com>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Eric Biggers <ebiggers@...nel.org>,
	"Theodore Y. Ts'o" <tytso@....edu>,
	Jaegeuk Kim <jaegeuk@...nel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-block@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	dm-devel@...ts.linux.dev
Subject: Re: [PATCH RESEND v7 11/17] soc: qcom: ice: add support for
 generating, importing and preparing keys

Hi Bartosz,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f486c8aa16b8172f63bddc70116a0c897a7f3f02]

url:    https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/blk-crypto-add-basic-hardware-wrapped-key-support/20241202-201228
base:   f486c8aa16b8172f63bddc70116a0c897a7f3f02
patch link:    https://lore.kernel.org/r/20241202-wrapped-keys-v7-11-67c3ca3f3282%40linaro.org
patch subject: [PATCH RESEND v7 11/17] soc: qcom: ice: add support for generating, importing and preparing keys
config: i386-buildonly-randconfig-006-20241203 (https://download.01.org/0day-ci/archive/20241203/202412030742.vCplCxJb-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241203/202412030742.vCplCxJb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412030742.vCplCxJb-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/soc/qcom/ice.c:528: warning: Function parameter or struct member 'ice' not described in 'qcom_ice_import_key'


vim +528 drivers/soc/qcom/ice.c

   512	
   513	/**
   514	 * qcom_ice_import_key() - Import a raw key for inline encryption
   515	 * ice: ICE driver data
   516	 * @imp_key: raw key that has to be imported
   517	 * @imp_key_size: size of the imported key
   518	 * @lt_key: longterm wrapped key that is imported, which is
   519	 *          BLK_CRYPTO_MAX_HW_WRAPPED_KEY_SIZE in size.
   520	 *
   521	 * Make a scm call into trustzone to import a raw key for storage encryption
   522	 * and generate a longterm wrapped key using hwkm.
   523	 *
   524	 * Return: 0 on success; -errno on failure.
   525	 */
   526	int qcom_ice_import_key(struct qcom_ice *ice, const u8 *imp_key, size_t imp_key_size,
   527				u8 lt_key[BLK_CRYPTO_MAX_HW_WRAPPED_KEY_SIZE])
 > 528	{
   529		size_t wk_size = QCOM_ICE_HWKM_WRAPPED_KEY_SIZE(ice->hwkm_version);
   530	
   531		if (!qcom_scm_import_ice_key(imp_key, imp_key_size, lt_key, wk_size))
   532			return wk_size;
   533	
   534		return 0;
   535	}
   536	EXPORT_SYMBOL_GPL(qcom_ice_import_key);
   537	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki