linux-kernel - Re: [PATCH v4 5/6] KVM: x86: Always complete hypercall via function callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z05NcpNLCgnL61jH@google.com>
Date: Mon, 2 Dec 2024 16:14:42 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Tom Lendacky <thomas.lendacky@....com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Binbin Wu <binbin.wu@...ux.intel.com>, Isaku Yamahata <isaku.yamahata@...el.com>, 
	Kai Huang <kai.huang@...el.com>, Xiaoyao Li <xiaoyao.li@...el.com>
Subject: Re: [PATCH v4 5/6] KVM: x86: Always complete hypercall via function callback

On Mon, Dec 02, 2024, Tom Lendacky wrote:
> On 12/2/24 14:57, Tom Lendacky wrote:
> > On 11/27/24 18:43, Sean Christopherson wrote:
> 
> >> @@ -10071,13 +10072,15 @@ unsigned long __kvm_emulate_hypercall(struct kvm_vcpu *vcpu, unsigned long nr,
> >>  	}
> >>  
> >>  out:
> >> -	return ret;
> >> +	vcpu->run->hypercall.ret = ret;
> >> +	complete_hypercall(vcpu);
> >> +	return 1;
> > 
> > Should this do return complete_hypercall(vcpu) so that you get the
> > return code from kvm_skip_emulated_instruction()?
> 
> Bah, ignore...  already commented on by Xiaoyao.

Reviewers: 2, Sean: 0

:-)