linux-kernel - Re: [PATCH v6 2/2] arm64: dts: qcom: sa8775p: Add support for clock controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gpikswuggsfnfu5ay3se46ah6rdehaeu5ylaa5aidmqtcejoo2@um7inmnjrcvq>
Date: Tue, 3 Dec 2024 09:32:31 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Taniya Das <quic_tdas@...cinc.com>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, quic_imrashai@...cinc.com, quic_jkona@...cinc.com, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Ajit Pandey <quic_ajipan@...cinc.com>
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: sa8775p: Add support for clock
 controllers

On Tue, Dec 03, 2024 at 10:04:13AM +0530, Taniya Das wrote:
> 
> 
> On 10/26/2024 12:12 AM, Konrad Dybcio wrote:
> > On 25.10.2024 8:42 PM, Konrad Dybcio wrote:
> > > On 25.10.2024 10:52 AM, Taniya Das wrote:
> > > > Add support for video, camera, display0 and display1 clock controllers
> > > > on SA8775P. The dispcc1 will be enabled based on board requirements.
> > 
> > Actually, why would that be? CCF should park it gracefully with
> > unused cleanup
> > 
> 
> Yes, CCF should take care to cleanup. But I am of an opinion that as we are
> aware that this platform do not require the dispcc1 so we could avoid the
> clock driver initialization and help in boot KPI.
> 

Does that imply that we're guaranteed that the bootloader will never
configure any clocks in dispcc1 that needs to be gracefully parked from
the OS? Is this guaranteed to be the case for all QCS9100 boards?

IMHO we should default to correctness, and then make product-specific
boot time optimizations from that starting point.

Regards,
Bjorn

> > Konrad
> > 
> > > > 
> > > > Reviewed-by: Jagadeesh Kona <quic_jkona@...cinc.com>
> > > > Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
> > > > ---
> > > 
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> > > 
> > > Konrad
> 
> -- 
> Thanks & Regards,
> Taniya Das.