linux-kernel - Re: [PATCH] media: marvell: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANeGvZXZAHJX=tE=4s8CxfzDioUU8_T6Agt9NEz_BOLQF8js3w@mail.gmail.com>
Date: Tue, 3 Dec 2024 15:22:01 -0500
From: Jiasheng Jiang <jiashengjiangcool@...il.com>
To: Hans Verkuil <hverkuil@...all.nl>
Cc: mchehab@...nel.org, andrzejtp2010@...il.com, allen.lkml@...il.com, 
	neil.armstrong@...aro.org, quic_jjohnson@...cinc.com, lkundrak@...sk, 
	sakari.ailus@...ux.intel.com, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: marvell: Add check for clk_enable()

Hi Hans,

On Tue, Dec 3, 2024 at 2:14 AM Hans Verkuil <hverkuil@...all.nl> wrote:
>
> Hi Jiasheng,
>
> On 21/11/2024 21:25, Jiasheng Jiang wrote:
> > Add check for the return value of clk_enable() to gurantee the success.
> >
> > Fixes: 81a409bfd551 ("media: marvell-ccic: provide a clock for the sensor")
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@...il.com>
> > ---
> >  drivers/media/platform/marvell/mcam-core.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/marvell/mcam-core.c b/drivers/media/platform/marvell/mcam-core.c
> > index 9ec01228f907..47023e701e12 100644
> > --- a/drivers/media/platform/marvell/mcam-core.c
> > +++ b/drivers/media/platform/marvell/mcam-core.c
> > @@ -935,7 +935,9 @@ static int mclk_enable(struct clk_hw *hw)
> >       ret = pm_runtime_resume_and_get(cam->dev);
> >       if (ret < 0)
> >               return ret;
> > -     clk_enable(cam->clk[0]);
> > +     ret = clk_enable(cam->clk[0]);
> > +     if (ret)
> > +             return ret;
>
> If clk_enable returns an error, doesn't this also require a call to pm_runtime_put() to
> balance the pm_runtime_resume_and_get() call?

Thanks. I will submit a v2 to add error handling.

-Jiasheng

> Regards,
>
>         Hans
>
> >       mcam_reg_write(cam, REG_CLKCTRL, (mclk_src << 29) | mclk_div);
> >       mcam_ctlr_power_up(cam);
> >
>