linux-kernel - Re: [RFC PATCH] resource: Fix CXL node not populated issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Z0-BM5KcS9PQcycg@smile.fi.intel.com>
Date: Wed, 4 Dec 2024 00:07:47 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Gregory Price <gourry@...rry.net>
Cc: "Huang, Ying" <ying.huang@...ux.alibaba.com>,
	Raghavendra K T <raghavendra.kt@....com>,
	linux-kernel@...r.kernel.org, linux-cxl <linux-cxl@...r.kernel.org>,
	Bharata B Rao <bharata@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	David Hildenbrand <david@...hat.com>,
	Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Alistair Popple <apopple@...dia.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Baoquan He <bhe@...hat.com>,
	ilpo.jarvinen@...ux.intel.com,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Fontenot Nathan <Nathan.Fontenot@....com>,
	Wei Huang <wei.huang2@....com>
Subject: Re: [RFC PATCH] resource: Fix CXL node not populated issue

On Tue, Dec 03, 2024 at 11:56:35AM -0800, Gregory Price wrote:
> On Tue, Dec 3, 2024, 6:09 AM Andy Shevchenko <
> andriy.shevchenko@...ux.intel.com> wrote:
> > On Tue, Dec 03, 2024 at 02:26:52PM +0800, Huang, Ying wrote:
> > > Raghavendra K T <raghavendra.kt@....com> writes:

...

> > > > git bisect had led to below commit
> > > > Fixes: b4afe4183ec7 ("resource: fix region_intersects() vs
> > add_memory_driver_managed()")
> > >
> > > This breaks you case, sorry about that.  But this also fixed a real bug
> > > too.  So, it's not appropriate just to revert it blindly.
> >
> > Linus was clear about this recently. Even if it fixes a bug, regression is
> > still regression
> 
> In my experience, region intersection issues often stem from bad CEDT
> entries.

Yeah, sometimes fixes may reveal the hidden issues.

> Have you dumped the ACPI tables on your system and validated the content?

I believe this is the Q to the original reporter.

> It would be a shame to revert a patch because the ACPI tables were wrong.

I agree with you and as I said in my reply "fixes are better than reverts".
I.o.w. I'm on the same page with Linus on this.

-- 
With Best Regards,
Andy Shevchenko