linux-kernel - Re: [PATCH v2] i2c: omap: Cleaned up coding style and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7B167CB3-EC8E-41C6-8A91-123167579475@goldelico.com>
Date: Tue, 3 Dec 2024 09:25:43 +0100
From: "H. Nikolaus Schaller" <hns@...delico.com>
To: Dhruv Menon <dhruvmenon1104@...il.com>
Cc: Aaro Koskinen <aaro.koskinen@....fi>,
 "Raghavendra, Vignesh" <vigneshr@...com>,
 andi.shyti@...nel.org,
 Janusz Krzysztofik <jmkrzyszt@...il.com>,
 tony Lindgren <tony@...mide.com>,
 Andreas Kemnade <andreas@...nade.info>,
 Kevin Hilman <khilman@...libre.com>,
 Roger Quadros <rogerq@...nel.org>,
 Linux-OMAP <linux-omap@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: omap: Cleaned up coding style and parameters

Just a minor nit:

> Am 03.12.2024 um 08:31 schrieb Dhruv Menon <dhruvmenon1104@...il.com>:
> 
> Hello Aaro, 
> 
> I have updated the patch as requiested, splitting it two parts,
> 
> 1. [PATCH v2 1/2] i2c: omap: Cleaned up coding style
> 2. [PATCH v2 2/2] i2c: omap: Removed unsed parameter

use "this patch will do" point of view, not "I have done"

=> Cleaned -> Clean

And there is a typo in "unsed".

> 
> I have also removed the changes regarding msleep as the adjustment
> was relatively minor. The change was initially considered based 
> on "Timer's howto" documentation which recommends to change any
> msleep(x) < 10ms to usleep_range(x*1000, x*2000) for better 
> precision.
> 
> Thank you for the time and review. I look forward to your feedback
> 
> Regards
> Dhruv Menon
>