linux-kernel - Re: [PATCH v3] i2c: omap: Cleaned up coding style and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z07QLveHUQlvDfIt@melbuntu>
Date: Tue, 3 Dec 2024 15:02:30 +0530
From: Dhruv Menon <dhruvmenon1104@...il.com>
To: "H. Nikolaus Schaller" <hns@...delico.com>
Cc: Aaro Koskinen <aaro.koskinen@....fi>,
	"Raghavendra, Vignesh" <vigneshr@...com>, andi.shyti@...nel.org,
	Janusz Krzysztofik <jmkrzyszt@...il.com>,
	tony Lindgren <tony@...mide.com>,
	Andreas Kemnade <andreas@...nade.info>,
	Kevin Hilman <khilman@...libre.com>,
	Roger Quadros <rogerq@...nel.org>,
	Linux-OMAP <linux-omap@...r.kernel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: omap: Cleaned up coding style and parameters

This patch has been splitted into two parts,

        1. [PATCH v2 1/2] i2c: omap: Clean up coding style
        2. [PATCH v2 2/2] i2c: omap: Removed unused parameter

The patchset also removed the changes regarding msleep as the 
adjustment was relatively minor which was added earlier. The 
change was initially considered based on "Timer's howto" 
documentation which recommends to change any msleep(x) < 10ms
to usleep_range(x*1000, x*2000) for better precision.

Thank you for the time and review. I look forward to your feedback

Regards
Dhruv Menon

On Tue, Dec 03, 2024 at 09:25:43AM +0100, H. Nikolaus Schaller wrote:
> Just a minor nit:
> 
> > Am 03.12.2024 um 08:31 schrieb Dhruv Menon <dhruvmenon1104@...il.com>:
> > 
> > Hello Aaro, 
> > 
> > I have updated the patch as requiested, splitting it two parts,
> > 
> > 1. [PATCH v2 1/2] i2c: omap: Cleaned up coding style
> > 2. [PATCH v2 2/2] i2c: omap: Removed unsed parameter
> 
> use "this patch will do" point of view, not "I have done"
> 
> => Cleaned -> Clean
> 
> And there is a typo in "unsed".
> 
> > 
> > I have also removed the changes regarding msleep as the adjustment
> > was relatively minor. The change was initially considered based 
> > on "Timer's howto" documentation which recommends to change any
> > msleep(x) < 10ms to usleep_range(x*1000, x*2000) for better 
> > precision.
> > 
> > Thank you for the time and review. I look forward to your feedback
> > 
> > Regards
> > Dhruv Menon
> > 
> 

View attachment "0000-cover-letter.patch" of type "text/x-diff" (507 bytes)

View attachment "0001-i2c-omap-Clean-up-coding-style.patch" of type "text/x-diff" (17483 bytes)

View attachment "0002-i2c-omap-remove-unused-parameter.patch" of type "text/x-diff" (2680 bytes)