linux-kernel - Re: [PATCH] drm/ci: add kms_cursor_legacy@...ture-bo to apq8016 flakes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19393604e18.f9b6fe7d298023.1937039548910081216@collabora.com>
Date: Wed, 04 Dec 2024 17:33:02 -0300
From: Helen Mae Koike Fornazier <helen.koike@...labora.com>
To: "Abhinav Kumar" <quic_abhinavk@...cinc.com>,
	"Vignesh Raman" <vignesh.raman@...labora.com>
Cc: "Rob Clark" <robdclark@...il.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@...aro.org>,
	"Sean Paul" <sean@...rly.run>,
	"Marijn Suijten" <marijn.suijten@...ainline.org>,
	"Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
	"Maxime Ripard" <mripard@...nel.org>,
	"Thomas Zimmermann" <tzimmermann@...e.de>,
	"David Airlie" <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm" <linux-arm-msm@...r.kernel.org>,
	"dri-devel" <dri-devel@...ts.freedesktop.org>,
	"freedreno" <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/ci: add kms_cursor_legacy@...ture-bo to apq8016
 flakes





---- On Wed, 04 Dec 2024 16:21:26 -0300 Abhinav Kumar  wrote ---

 > Hi Helen 
 >  
 > On 12/4/2024 11:14 AM, Helen Mae Koike Fornazier wrote: 
 > > Hi Abhinav, 
 > > 
 > > Thanks for your patch. 
 > > 
 > > 
 > > 
 > > ---- On Wed, 04 Dec 2024 15:55:17 -0300 Abhinav Kumar  wrote --- 
 > > 
 > >   > From the jobs [1] and [2] of pipeline [3], its clear that 
 > >   > kms_cursor_legacy@...ture-bo is most certainly a flake and 
 > >   > not a fail for apq8016. Mark the test accordingly to match the results. 
 > >   > 
 > >   > [1] : https://gitlab.freedesktop.org/drm/msm/-/jobs/67676481 
 > >   > [2] : https://gitlab.freedesktop.org/drm/msm/-/jobs/67677430 
 > >   > [3]: https://gitlab.freedesktop.org/drm/msm/-/pipelines/1322770 
 > >   > 
 > >   > Signed-off-by: Abhinav Kumar quic_abhinavk@...cinc.com> 
 > >   > --- 
 > >   >  drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt | 5 +++++ 
 > >   >  1 file changed, 5 insertions(+) 
 > >   > 
 > >   > diff --git a/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt b/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt 
 > >   > new file mode 100644 
 > >   > index 000000000000..18639853f18f 
 > >   > --- /dev/null 
 > >   > +++ b/drivers/gpu/drm/ci/xfails/msm-apq8016-flakes.txt 
 > >   > @@ -0,0 +1,5 @@ 
 > >   > +# Board Name: msm-apq8016-db410c 
 > >   > +# Failure Rate: 100 
 > > 
 > > Is failure rate is 100%, isn't it a fail than? 
 > > (I know we have other cases with Failure Rate: 100, maybe we should fix them as well) 
 > > 
 >  
 > Maybe I misunderstood the meaning of "Failure rate" for a flake. 
 >  
 > I interpreted this as this test being flaky 100% of the time :) 

Ah right, I see, inside deqp-runner (that auto-retries).

I'd like to hear Vignesh's opinion on this.

(In any case, we probably should document this better)

Regards,
Helen

 >  
 > Out of the 3 runs of the test, it passed 2/3 times and failed 1/3. 
 >  
 > So its fail % actually is 33.33% in that case. 
 >  
 > I think I saw a Failure rate of 100% on msm-sm8350-hdk-flakes.txt and 
 > mistook that as the rate at which flakes are seen. 
 >  
 > Let me fix this up as 33% 
 >  
 > > Regards, 
 > > Helen 
 > > 
 > >   > +# IGT Version: 1.28-ga73311079 
 > >   > +# Linux Version: 6.12.0-rc2 
 > >   > +kms_cursor_legacy@...ture-bo 
 > >   > 
 > >   > --- 
 > >   > base-commit: 798bb342e0416d846cf67f4725a3428f39bfb96b 
 > >   > change-id: 20241204-cursor_tor_skip-9d128dd62c4f 
 > >   > 
 > >   > Best regards, 
 > >   > -- 
 > >   > Abhinav Kumar quic_abhinavk@...cinc.com> 
 > >   > 
 > >   > 
 > > 
 >