linux-kernel - Re: [PATCH] selftests: prctl: Fix resource leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0fc34fa-d208-4bd2-8e0d-bfba60b06b90@linuxfoundation.org>
Date: Wed, 4 Dec 2024 16:00:44 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: liujing <liujing@...s.chinamobile.com>, shuah@...nel.org,
 osmtendev@...il.com
Cc: linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: prctl: Fix resource leaks

On 11/27/24 23:18, liujing wrote:
> After using the fopen function successfully, you need to call
> fclose to close the file before finally returning.
> 
> Signed-off-by: liujing <liujing@...s.chinamobile.com>
> 
> diff --git a/tools/testing/selftests/prctl/set-process-name.c b/tools/testing/selftests/prctl/set-process-name.c
> index 562f707ba771..7be7afff0cd2 100644
> --- a/tools/testing/selftests/prctl/set-process-name.c
> +++ b/tools/testing/selftests/prctl/set-process-name.c
> @@ -66,9 +66,12 @@ int check_name(void)
>   		return -EIO;
>   
>   	fscanf(fptr, "%s", output);
> -	if (ferror(fptr))
> +	if (ferror(fptr)) {
> +		fclose(fptr);
>   		return -EIO;
> +	}
>   
> +	fclose(fptr);
>   	int res = prctl(PR_GET_NAME, name, NULL, NULL, NULL);
>   
>   	if (res < 0)

How did you find this problem? This file will be closed when
the test exits - do you need this fclose()?

thanks,
-- Shuah