linux-kernel - Re: [PATCH v3 06/10] dt-bindings: iio: accel: add interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7tj5n3hsthhlpo4quj5anazotvte2f74jvpev362e6ivbtza67@pj6n3r4ooees>
Date: Wed, 4 Dec 2024 08:29:02 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	devicetree@...r.kernel.org, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	eraretuya@...il.com
Subject: Re: [PATCH v3 06/10] dt-bindings: iio: accel: add interrupt-names

On Tue, Dec 03, 2024 at 08:52:37PM +0000, Lothar Rubusch wrote:
> Add interrupt-names INT1 and INT2 for the two interrupt lines of the
> sensor. Only one line will be connected for incoming events. The driver
> needs to be configured accordingly. If no interrupt line is set up, the
> sensor will still measure, but no events are possible.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
> ---
>  .../devicetree/bindings/iio/accel/adi,adxl345.yaml  | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> index 280ed479ef5..c3483a4b652 100644
> --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> @@ -37,6 +37,17 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  interrupt-names:
> +    Data ready is only available on INT1, but events can use either or
> +    both pins.  If not specified, first element assumed to correspond
> +    to INT1 and second (where present) to INT2.
> +  minItems: 1
> +  maxItems: 2

This does not match your interrupts property.


> +  items:
> +    enum:
> +      - INT1
> +      - INT2

Best regards,
Krzysztof