linux-kernel - Re: [PATCH v3 10/10] iio: accel: adxl345: add kfifo with watermark

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202412041901.a986bAPP-lkp@intel.com>
Date: Wed, 4 Dec 2024 19:43:57 +0800
From: kernel test robot <lkp@...el.com>
To: Lothar Rubusch <l.rubusch@...il.com>, lars@...afoo.de,
	Michael.Hennerich@...log.com, jic23@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	eraretuya@...il.com, l.rubusch@...il.com
Subject: Re: [PATCH v3 10/10] iio: accel: adxl345: add kfifo with watermark

Hi Lothar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.13-rc1 next-20241203]
[cannot apply to jic23-iio/togreg v6.13-rc1 v6.12 v6.12-rc7 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lothar-Rubusch/iio-accel-adxl345-fix-comment-on-probe/20241204-121629
base:   linus/master
patch link:    https://lore.kernel.org/r/20241203205241.48077-11-l.rubusch%40gmail.com
patch subject: [PATCH v3 10/10] iio: accel: adxl345: add kfifo with watermark
config: i386-buildonly-randconfig-004 (https://download.01.org/0day-ci/archive/20241204/202412041901.a986bAPP-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241204/202412041901.a986bAPP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412041901.a986bAPP-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/accel/adxl345_core.c:434: warning: expecting prototype for irqreturn_t adxl345_event_handler()(). Prototype was for adxl345_event_handler() instead


vim +434 drivers/iio/accel/adxl345_core.c

   425	
   426	/**
   427	 * irqreturn_t adxl345_event_handler() - Handle events of the ADXL345.
   428	 * @irq: The irq being handled.
   429	 * @p: The struct iio_device pointer for the device.
   430	 *
   431	 * Return: The interrupt was handled.
   432	 */
   433	static irqreturn_t adxl345_event_handler(int irq, void *p)
 > 434	{
   435		struct iio_dev *indio_dev = p;
   436		struct adxl345_state *st = iio_priv(indio_dev);
   437		u8 int_stat;
   438		int samples;
   439	
   440		int_stat = adxl345_get_status(st);
   441		if (int_stat < 0)
   442			return IRQ_NONE;
   443	
   444		if (int_stat == 0x0)
   445			goto err;
   446	
   447		if (int_stat & ADXL345_INT_OVERRUN)
   448			goto err;
   449	
   450		if (int_stat & (ADXL345_INT_DATA_READY | ADXL345_INT_WATERMARK)) {
   451			samples = adxl345_get_samples(st);
   452			if (samples < 0)
   453				goto err;
   454	
   455			if (adxl345_fifo_push(indio_dev, samples) < 0)
   456				goto err;
   457	
   458		}
   459		return IRQ_HANDLED;
   460	
   461	err:
   462		adxl345_fifo_reset(st);
   463	
   464		return IRQ_HANDLED;
   465	}
   466	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki