linux-kernel - Re: [PATCH v3 1/5] sched_ext: Implement scx_rq_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <853dc59e-d83d-49ea-8a2e-1f519234ec0a@igalia.com>
Date: Wed, 4 Dec 2024 10:28:23 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Tejun Heo <tj@...nel.org>
Cc: void@...ifault.com, mingo@...hat.com, peterz@...radead.org,
 kernel-dev@...lia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/5] sched_ext: Implement scx_rq_clock_update/stale()

Hello,

On 24. 12. 4. 08:23, Tejun Heo wrote:
> Hello,
> 
> On Tue, Dec 03, 2024 at 11:27:58PM +0900, Changwoo Min wrote:
> ...
>> @@ -2505,19 +2538,6 @@ extern const struct sched_class rt_sched_class;
>>   extern const struct sched_class fair_sched_class;
>>   extern const struct sched_class idle_sched_class;
>>   
>> -#ifdef CONFIG_SCHED_CLASS_EXT
>> -extern const struct sched_class ext_sched_class;
>> -
>> -DECLARE_STATIC_KEY_FALSE(__scx_ops_enabled);	/* SCX BPF scheduler loaded */
>> -DECLARE_STATIC_KEY_FALSE(__scx_switched_all);	/* all fair class tasks on SCX */
>> -
>> -#define scx_enabled()		static_branch_unlikely(&__scx_ops_enabled)
>> -#define scx_switched_all()	static_branch_unlikely(&__scx_switched_all)
>> -#else /* !CONFIG_SCHED_CLASS_EXT */
>> -#define scx_enabled()		false
>> -#define scx_switched_all()	false
>> -#endif /* !CONFIG_SCHED_CLASS_EXT */
> 
> Can you please separate out code relocations into a separate patch? Here,
> it's on the smaller side but patches are difficult to read when they're
> mixed up.

Thanks for the comment! I will separate the code relocation out
in the next version.

Regards,
Changwoo Min