linux-kernel - Re: [PATCH] sh: pci: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXu04CFhkc3E=cA9wi_eigc1q88azb8k5N4UeyMAgKOkw@mail.gmail.com>
Date: Wed, 4 Dec 2024 13:35:12 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: liujing <liujing@...s.chinamobile.com>
Cc: ysato@...rs.sourceforge.jp, dalias@...c.org, glaubitz@...sik.fu-berlin.de, 
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: pci: Fix the wrong format specifier

Hi Liujing,

On Wed, Dec 4, 2024 at 12:10 PM liujing <liujing@...s.chinamobile.com> wrote:
> Make a minor change to eliminate a static checker warning. The type
> of port->index is unsigned int, so the correct format specifier should be
> %u instead of %d.
>
> Signed-off-by: liujing <liujing@...s.chinamobile.com>

Thanks for your patch!

> --- a/arch/sh/drivers/pci/pcie-sh7786.c
> +++ b/arch/sh/drivers/pci/pcie-sh7786.c
> @@ -219,7 +219,7 @@ static int __init pcie_clk_init(struct sh7786_pcie_port *port)
>          * on. clock lookups don't help us much at this point, since no
>          * dev_id is available this early. Lame.
>          */
> -       snprintf(fclk_name, sizeof(fclk_name), "pcie%d_fck", port->index);
> +       snprintf(fclk_name, sizeof(fclk_name), "pcie%u_fck", port->index);
>
>         port->fclk = clk_get(NULL, fclk_name);
>         if (IS_ERR(port->fclk)) {

LGTM, but there are several more cases to fix in this file.
Please fix all of them in a single patch.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds