linux-kernel - Re: [PATCH] sh: pci: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c37eb9306b9eef2a93720947817d5838ee48dbc.camel@physik.fu-berlin.de>
Date: Thu, 30 Jan 2025 09:24:03 +0100
From: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>, liujing
	 <liujing@...s.chinamobile.com>
Cc: ysato@...rs.sourceforge.jp, dalias@...c.org, linux-sh@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: pci: Fix the wrong format specifier

Hi Liujing,

On Wed, 2024-12-04 at 13:35 +0100, Geert Uytterhoeven wrote:
> Hi Liujing,
> 
> On Wed, Dec 4, 2024 at 12:10 PM liujing <liujing@...s.chinamobile.com> wrote:
> > Make a minor change to eliminate a static checker warning. The type
> > of port->index is unsigned int, so the correct format specifier should be
> > %u instead of %d.
> > 
> > Signed-off-by: liujing <liujing@...s.chinamobile.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/sh/drivers/pci/pcie-sh7786.c
> > +++ b/arch/sh/drivers/pci/pcie-sh7786.c
> > @@ -219,7 +219,7 @@ static int __init pcie_clk_init(struct sh7786_pcie_port *port)
> >          * on. clock lookups don't help us much at this point, since no
> >          * dev_id is available this early. Lame.
> >          */
> > -       snprintf(fclk_name, sizeof(fclk_name), "pcie%d_fck", port->index);
> > +       snprintf(fclk_name, sizeof(fclk_name), "pcie%u_fck", port->index);
> > 
> >         port->fclk = clk_get(NULL, fclk_name);
> >         if (IS_ERR(port->fclk)) {
> 
> LGTM, but there are several more cases to fix in this file.
> Please fix all of them in a single patch.

Could you send a V2 of your patch and make the changes recommended by Geert?

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913