linux-kernel - Re: [PATCH v4 06/10] dt-bindings: iio: accel: add interrupt-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFXKEHYEyTHX+iDR+sCY9n4aPgWkZ9qMENbSq-ohMWWNUq1REQ@mail.gmail.com>
Date: Thu, 5 Dec 2024 17:55:33 +0100
From: Lothar Rubusch <l.rubusch@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com, jic23@...nel.org, 
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	devicetree@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, eraretuya@...il.com
Subject: Re: [PATCH v4 06/10] dt-bindings: iio: accel: add interrupt-names

On Thu, Dec 5, 2024 at 9:55 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Wed, Dec 04, 2024 at 06:24:47PM +0000, Lothar Rubusch wrote:
> > Add interrupt-names INT1 and INT2 for the two interrupt lines of the
> > sensor. Only one line will be connected for incoming events. The driver
> > needs to be configured accordingly. If no interrupt line is set up, the
> > sensor will still measure, but no events are possible.
> >
> > Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
> > ---
> >  .../devicetree/bindings/iio/accel/adi,adxl345.yaml    | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > index 280ed479ef5..a4c2cefe1a4 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml
> > @@ -37,6 +37,15 @@ properties:
> >    interrupts:
> >      maxItems: 1
> >
> > +  interrupt-names:
> > +    description: Use either INT1 or INT2 for events, or ignore events.
> > +    minItems: 1
> > +    maxItems: 2
>
> No improvements, no responses and according to commit msg you have only

That's not true. Indention was now fixed.

> one item, so instead above and below just:
>
> description: .........
> items:
>  - enum: [ int1, int2]

Yes. Unfortunately you're right. I was not aware of the [] writing. Much better!

Sorry, for wasting your time with that. I learned to not just
copy&paste w/o running the lengthy dt_binding_check. Fixed version is
coming up.

Best,
L

>
> Best regards,
> Krzysztof
>