linux-kernel - Re: [PATCH] scsi:ufs:core: update compl_time_stamp_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <febcd6eb3565feaf09d21a8c78fd7412be88e0c1.camel@mediatek.com>
Date: Thu, 5 Dec 2024 05:52:34 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "ahalaney@...hat.com" <ahalaney@...hat.com>, "quic_mnaresh@...cinc.com"
	<quic_mnaresh@...cinc.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>,
	"avri.altman@....com" <avri.altman@....com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "liuderong@...o.com" <liuderong@...o.com>,
	"bvanassche@....org" <bvanassche@....org>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after
 complete a cqe

On Wed, 2024-12-04 at 19:50 +0800, liuderong@...o.com wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> From: liuderong <liuderong@...o.com>
> 
> For now, lrbp->compl_time_stamp_local_clock is set to zero
> after send a sqe, but it is not updated after complete a cqe,
> the printed information in ufshcd_print_tr will always be zero.
> So update lrbp->cmpl_time_stamp_local_clock after complete a cqe.
> 
> Log sample:
> ufshcd-qcom 1d84000.ufshc: UPIU[8] - issue time 8750227249 us
> ufshcd-qcom 1d84000.ufshc: UPIU[8] - complete time 0 us
> 
> Signed-off-by: liuderong <liuderong@...o.com>
> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
> 
>         lrbp = &hba->lrb[task_tag];
>         lrbp->compl_time_stamp = ktime_get();
> +       lrbp->compl_time_stamp_local_clock = local_clock();
>         cmd = lrbp->cmd;
>         if (cmd) {
>                 if (unlikely(ufshcd_should_inform_monitor(hba,
> lrbp)))
> --
> 2.7.4

Reviewed-by: Peter Wang <peter.wang@...iatek.com>


>