linux-kernel - RE: [PATCH] scsi:ufs:core: update compl_time_stamp_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR04MB657515591FEBC6EA15DC209BFC302@DM6PR04MB6575.namprd04.prod.outlook.com>
Date: Thu, 5 Dec 2024 09:07:31 +0000
From: Avri Altman <Avri.Altman@....com>
To: "liuderong@...o.com" <liuderong@...o.com>, "alim.akhtar@...sung.com"
	<alim.akhtar@...sung.com>, "bvanassche@....org" <bvanassche@....org>,
	"James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "peter.wang@...iatek.com"
	<peter.wang@...iatek.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "ahalaney@...hat.com"
	<ahalaney@...hat.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>,
	"quic_mnaresh@...cinc.com" <quic_mnaresh@...cinc.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi:ufs:core: update compl_time_stamp_local_clock after
 complete a cqe

> 
> From: liuderong <liuderong@...o.com>
> 
> For now, lrbp->compl_time_stamp_local_clock is set to zero after send a sqe,
> but it is not updated after complete a cqe, the printed information in
> ufshcd_print_tr will always be zero.
> So update lrbp->cmpl_time_stamp_local_clock after complete a cqe.
> 
> Log sample:
> ufshcd-qcom 1d84000.ufshc: UPIU[8] - issue time 8750227249 us ufshcd-qcom
> 1d84000.ufshc: UPIU[8] - complete time 0 us
Fixes tag?
I think that the commit that dropped updating it is:
c30d8d010b5e scsi: ufs: core: Prepare for completion in MCQ.

Thanks,
Avri

> 
> Signed-off-by: liuderong <liuderong@...o.com>
> ---
>  drivers/ufs/core/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
> 
>         lrbp = &hba->lrb[task_tag];
>         lrbp->compl_time_stamp = ktime_get();
> +       lrbp->compl_time_stamp_local_clock = local_clock();
>         cmd = lrbp->cmd;
>         if (cmd) {
>                 if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))
> --
> 2.7.4