linux-kernel - Re: [PATCH RFC 2/2] mailbox: tmelite-qmp: Introduce QCOM TMEL QMP mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73312ce2-753d-4790-8b90-515d3c429c47@quicinc.com>
Date: Thu, 5 Dec 2024 14:37:03 +0530
From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, <jassisinghbrar@...il.com>,
        <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH RFC 2/2] mailbox: tmelite-qmp: Introduce QCOM TMEL QMP
 mailbox driver



On 12/5/2024 1:44 PM, Krzysztof Kozlowski wrote:
> On 05/12/2024 09:06, Sricharan R wrote:
>> From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
>>
>> The QMP mailbox is the primary means of communication between TME-L SS
>> and other subsystem on the SoC. A dedicated pair of inbound and outbound
>> mailboxes is implemented for each subsystem/external execution environment
>> which needs to communicate with TME-L for security services. The inbound
>> mailboxes are used to send IPC requests to TME-L, which are then processed
>> by TME-L firmware and accordingly the responses are sent to the requestor
>> via outbound mailboxes.
>>
>> It is an IPC transport protocol which is light weight and supports
>> a subset of API's. It handles link initialization, negotiation,
>> establishment and communication across client(APPSS/BTSS/AUDIOSS)
>> and server(TME-L SS).
>>
>>     -----------------------------------------------       ---------------------------------------------------
>>    |                                              |       |                                                 |
>>    |                 SOC  CLIENT                  | SOC   |                TME-L  SS                        |
>>    |                                              | AHB   |                                                 |
>>    |     ----------    ---------   ---------      |       | ------    -------     --------    ------------  |
>>    |     |        |    |       |   |       |      | WO    | |     | R |     |     |      |    |SERVICES   | |
>>    |     | APPS   |<-->| TMEL  |<->|       |------------->| | IN  |-->|     |     | TMEL |    |--------   | |
>>    |     |        |    | COM   |   | QMP   |      | RO    | |     | W | QMP |<--->| COM  |<-->| a) ATTEST | |
>>    |     |        |    |       |   |       |<-------------| | OUT |<--|     |     |      |    | b) CRYPTO | |
>>    |     |        |    |       |   |       |      |       | |     |   |     |     |      |    | .. more   | |
>>    |     ---------     ---------   ---------      |       | ------    -------     -------     ------------  |
>>    |                                              |       |                                                 |
>>     -----------------------------------------------       --------------------------------------------------
> 
> 
> Hardware description is much more suitable for the binding, not to the
> driver. You wrote the same in cover letter and here... but not in actual
> hardware description - binding.
> 
ok, will fix and add to the binding doc.

>>
>> TME-L SS provides different kinds of services like secureboot, remote image authentication,
>> key management, crypto, OEM provisioning etc. This patch adds support for remote image
>> authentication. Support for rest of the services can be added.
> 
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 
ok will fix.

>>
>> Remote proc driver subscribes to this mailbox and uses the mbox_send_message to use
>> TME-L to securely authenticate/teardown the images.
>>
>> The intention of posting this is to get the design reviewed/corrected since there are also
>> other possible ways of having this SS support.
> 
> 
> If you do not Cc maintainers, don't expect much answer. Missing Qcom amd
> remoteproc maintainers.
> 
> 
ho ok, added all from get_maintainers.pl, but since its new file not
sure if everyone is listed. Will ensure to CC others as well.

Regards,
  Sricharan