linux-kernel - Re: [PATCH v10 0/2] Add support for nuvoton ma35 nand controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qsuwhm1.fsf@bootlin.com>
Date: Thu, 05 Dec 2024 11:26:30 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Hui-Ping Chen <hpchen0nvt@...il.com>
Cc: richard@....at,  vigneshr@...com,  robh@...nel.org,  krzk+dt@...nel.org,
  conor+dt@...nel.org,  nikita.shubin@...uefel.me,  arnd@...db.de,
  vkoul@...nel.org,  esben@...nix.com,
  linux-arm-kernel@...ts.infradead.org,  linux-mtd@...ts.infradead.org,
  devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 0/2] Add support for nuvoton ma35 nand controller

Hi,

On 04/12/2024 at 02:51:27 GMT, Hui-Ping Chen <hpchen0nvt@...il.com> wrote:

> This patch series adds the mtd nand driver for the nuvoton ma35 ARMv8 SoC.
> It includes DT binding documentation and the ma35 mtd nand driver.
>
> v10:
>   - Update ma35d1 mtd nand driver
>     - Add unsupported write page handling.

I was about to apply it but...

    [31m●[0m checkpatch.pl: 117: WARNING: please write a help paragraph that fully describes the config symbol
    [31m●[0m checkpatch.pl: 141: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
    [31m●[0m checkpatch.pl: 348: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 352: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 352: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 429: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 465: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 465: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 466: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 466: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 467: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 467: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 468: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 468: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 479: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 479: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 481: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 481: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 514: CHECK: Unbalanced braces around else statement
    [31m●[0m checkpatch.pl: 611: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 650: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 665: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 675: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 689: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 699: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 715: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 756: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 805: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 935: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 950: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 953: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 975: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1001: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1018: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1131: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1159: WARNING: DT compatible string "nuvoton,ma35d1-nand" appears un-documented -- check ./Documentation/devicetree/bindings/

Please fix these warnings and checks.

You might want to use --strict by default.

Thanks,
Miquèl