linux-kernel - Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eyu7nm5hvwfqxgysnrzsvianzf7abvlovpxfo7snsxowmuuhpj@tah3gkqm5ldj>
Date: Thu, 5 Dec 2024 11:37:29 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: quic_zijuhu <quic_zijuhu@...cinc.com>
Cc: Zijun Hu <zijun_hu@...oud.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, James Bottomley <James.Bottomley@...senpartnership.com>, 
	Thomas Weißschuh <thomas@...ch.de>, linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev, 
	linux-sound@...r.kernel.org, sparclinux@...r.kernel.org, linux-block@...r.kernel.org, 
	linux-cxl@...r.kernel.org, linux1394-devel@...ts.sourceforge.net, arm-scmi@...r.kernel.org, 
	linux-efi@...r.kernel.org, linux-gpio@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-mediatek@...ts.infradead.org, linux-hwmon@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-pwm@...r.kernel.org, linux-remoteproc@...r.kernel.org, linux-scsi@...r.kernel.org, 
	open-iscsi@...glegroups.com, linux-usb@...r.kernel.org, linux-serial@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

On Thu, Dec 05, 2024 at 04:37:08PM +0800, quic_zijuhu wrote:
> On 12/5/2024 4:10 PM, Uwe Kleine-König wrote:
> > On Thu, Dec 05, 2024 at 08:10:17AM +0800, Zijun Hu wrote:
> >> From: Zijun Hu <quic_zijuhu@...cinc.com>
> >>
> >> gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
> >> Remvoe the unnecessary wrapper.

Just spotted: s/Remvoe/Remove/

> >> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> >> ---
> >>  drivers/gpio/gpio-sim.c | 7 +------
> > 
> > I think if you move this patch before patch #4 in your series, you only
> > have to touch this file once.
> 
> the precondition of this change is patch #4, it will have building error
> if moving it before #4.
> 
> actually, we can only do simplifications with benefits brought by #4.

Ah I see. I thought that device_match_fwnode only got the const for the
2nd parameter in patch #4.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)