linux-kernel - Re: [PATCH v3 04/11] driver core: Constify API device_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <h4pndknfwvck5yjnbs5rdmrxkqeksfxldwj4qbjqyvdzs5cjbf@i4afsjsg3obw>
Date: Thu, 5 Dec 2024 11:41:56 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	James Bottomley <James.Bottomley@...senpartnership.com>, Thomas Weißschuh <thomas@...ch.de>, 
	linux-kernel@...r.kernel.org, nvdimm@...ts.linux.dev, linux-sound@...r.kernel.org, 
	sparclinux@...r.kernel.org, linux-block@...r.kernel.org, linux-cxl@...r.kernel.org, 
	linux1394-devel@...ts.sourceforge.net, arm-scmi@...r.kernel.org, linux-efi@...r.kernel.org, 
	linux-gpio@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-mediatek@...ts.infradead.org, linux-hwmon@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-pwm@...r.kernel.org, linux-remoteproc@...r.kernel.org, linux-scsi@...r.kernel.org, 
	open-iscsi@...glegroups.com, linux-usb@...r.kernel.org, linux-serial@...r.kernel.org, 
	netdev@...r.kernel.org, Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v3 04/11] driver core: Constify API device_find_child()
 then adapt for various usages

On Thu, Dec 05, 2024 at 08:10:13AM +0800, Zijun Hu wrote:
> diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
> index 07933d75ac815160a2580dce39fde7653a9502e1..1a1a9d6b8f2e8dfedefafde846315a06a167fbfb 100644
> --- a/arch/sparc/kernel/vio.c
> +++ b/arch/sparc/kernel/vio.c
> @@ -419,13 +419,13 @@ struct vio_remove_node_data {
>  	u64 node;
>  };
>  
> -static int vio_md_node_match(struct device *dev, void *arg)
> +static int vio_md_node_match(struct device *dev, const void *arg)
>  {
>  	struct vio_dev *vdev = to_vio_dev(dev);
> -	struct vio_remove_node_data *node_data;
> +	const struct vio_remove_node_data *node_data;
>  	u64 node;
>  
> -	node_data = (struct vio_remove_node_data *)arg;
> +	node_data = (const struct vio_remove_node_data *)arg;

You can just drop the cast here. But maybe that is better be done i a
separate change.

>  	node = vio_vdev_node(node_data->hp, vdev);
>  

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)