linux-kernel - Re: [PATCH v2 00/21] Converge on using secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dab77729-682f-4182-9fb2-cd522ac29b5f@linux.microsoft.com>
Date: Fri, 6 Dec 2024 12:58:17 -0800
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: eahariha@...ux.microsoft.com, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, cocci@...ia.fr,
 linux-arm-kernel@...ts.infradead.org, linux-s390@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 linux-scsi@...r.kernel.org, xen-devel@...ts.xenproject.org,
 linux-block@...r.kernel.org, linux-wireless@...r.kernel.org,
 ath11k@...ts.infradead.org, linux-mm@...ck.org,
 linux-bluetooth@...r.kernel.org, linux-staging@...ts.linux.dev,
 linux-rpi-kernel@...ts.infradead.org, ceph-devel@...r.kernel.org,
 live-patching@...r.kernel.org, linux-sound@...r.kernel.org,
 etnaviv@...ts.freedesktop.org, oss-drivers@...igine.com,
 linuxppc-dev@...ts.ozlabs.org, Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

On 11/29/2024 4:57 AM, Przemek Kitszel wrote:
> 
> [removed most non-list recipients, it's just too much]
> 
> On 11/15/24 10:26 PM, Easwar Hariharan wrote:
<snip>
>>
>> ---
>> Changes in v2:
>> - EDITME: describe what is new in this series revision.
>> - EDITME: use bulletpoints and terse descriptions.
>> - Link to v1: https://lore.kernel.org/r/20241115-converge-secs-to-
>> jiffies-v1-0-19aadc34941b@...ux.microsoft.com
> 
> that is not a proper changelog, you were supposed to edit those
> placeholder entries; please look around for examples
> 
> There is also just too much recipients. Please split up your patches
> into smaller pieces. You will also learn the process on a smaller
> sample.
> 
> And definitively please wait for 48h before reposting such big series.

Yes, sorry, I sent out a v2 in a moment of panic on including the
already accepted patch in v1. I failed to edit the changelog in that
same panic. I'll try to not panic and do better in the future.

> 
> Regarding code - you could also convert msecs_to_jiffies(const * HZ),
> there are 10 that are greppable.
> 

Those seem to be mistakes. const*HZ is a seconds-denominated timeout,
being passed to msecs_to_jiffies() which will treat it as a
millisecond-denominated timeout resulting in an excessively long
timeout. I suppose that's better than a too-short timeout, and
apparently it's been working fine all along since hardware responds
before the too-long timeout expires. Half of them are in
drivers/scsi/arcmsr/arcmsr_hba.c and the pattern has apparently been
there since 2010.

Thanks,
Easwar