linux-kernel - Re: [PATCH v2 00/21] Converge on using secs_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72c8eb66-eb67-4f8b-b0c0-13f1aa001698@intel.com>
Date: Mon, 9 Dec 2024 13:01:42 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Easwar Hariharan <eahariha@...ux.microsoft.com>
CC: <netfilter-devel@...r.kernel.org>, <coreteam@...filter.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <cocci@...ia.fr>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
	<dri-devel@...ts.freedesktop.org>, <intel-xe@...ts.freedesktop.org>,
	<linux-scsi@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	<linux-block@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<ath11k@...ts.infradead.org>, <linux-mm@...ck.org>,
	<linux-bluetooth@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
	<linux-rpi-kernel@...ts.infradead.org>, <ceph-devel@...r.kernel.org>,
	<live-patching@...r.kernel.org>, <linux-sound@...r.kernel.org>,
	<etnaviv@...ts.freedesktop.org>, <oss-drivers@...igine.com>,
	<linuxppc-dev@...ts.ozlabs.org>, Anna-Maria Behnsen
	<anna-maria@...utronix.de>
Subject: Re: [PATCH v2 00/21] Converge on using secs_to_jiffies()

On 12/6/24 9:58 PM, Easwar Hariharan wrote:
> On 11/29/2024 4:57 AM, Przemek Kitszel wrote:
>>
>> [removed most non-list recipients, it's just too much]
>>
>> On 11/15/24 10:26 PM, Easwar Hariharan wrote:
> <snip>

>>
>> Regarding code - you could also convert msecs_to_jiffies(const * HZ),
>> there are 10 that are greppable.
>>
> 
> Those seem to be mistakes. const*HZ is a seconds-denominated timeout,
> being passed to msecs_to_jiffies() which will treat it as a
> millisecond-denominated timeout resulting in an excessively long
> timeout. I suppose that's better than a too-short timeout, and
> apparently it's been working fine all along since hardware responds
> before the too-long timeout expires. Half of them are in
> drivers/scsi/arcmsr/arcmsr_hba.c and the pattern has apparently been
> there since 2010.

my point was that, the default value of HZ is 1000, and most of the code
that is just `$value*HZ` was meant as "$value seconds, in ms unit".

Same for HZ/const, HZ/2 being 500ms.

HZ is awful in that it is not 1s but 1/s, but it was easy to abuse the
value in simple context.

If you happen to touch this, please do in a separate series, to get more
attention from drivers owners.

> 
> Thanks,
> Easwar