linux-kernel - Re: [PATCH 11/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2515c9d8-0e9d-4e1e-b8ff-764b53ea3edb@quicinc.com>
Date: Fri, 6 Dec 2024 10:18:50 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <vladimir.zapolskiy@...aro.org>
CC: <quic_eberman@...cinc.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>,
        Yongsheng Li
	<quic_yon@...cinc.com>
Subject: Re: [PATCH 11/16] dt-bindings: media: camss: Add qcom,sm8550-camss
 binding

Hi Bryan,

On 12/6/2024 12:11 AM, Bryan O'Donoghue wrote:
> On 05/12/2024 15:55, Depeng Shao wrote:
>> +            iommus = <&apps_smmu 0x800 0x20>;
> 
> This iommu list looks a bit spartan.
> 
> Here's what I have for X1E:
> 
> https://git.codelinaro.org/bryan.odonoghue/kernel/-/ 
> commit/9686eaf9557c386a2525d6668da6fe24ffd518c4#5b6ff684e5292a4c0b51f6a38631777fafae7561_4749_4874
> 
> Could you double check this list ?
> 

Since the camss driver just support ife, so I think only ife related 
iommus are needed, just like we don't add ipe,bps,jpeg related clk and 
register in the dt-binding.

	msm_cam_smmu_ife { 
  

		compatible = "qcom,msm-cam-smmu-cb"; 
  

		iommus = <&apps_smmu 0x800 0x20>;
		......
	};

> ---
> bod


Thanks,
Depeng