linux-kernel - Re: [PATCH 12/16] media: qcom: camss: Add default case in vfe_src_pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25cfe320-a8cd-44e9-85e1-fb833f65fb7e@quicinc.com>
Date: Fri, 6 Dec 2024 10:20:44 +0800
From: Depeng Shao <quic_depengs@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, <rfoss@...nel.org>,
        <todor.too@...il.com>, <mchehab@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <vladimir.zapolskiy@...aro.org>
CC: <quic_eberman@...cinc.com>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel@...cinc.com>
Subject: Re: [PATCH 12/16] media: qcom: camss: Add default case in
 vfe_src_pad_code

Hi Bryan,

On 12/6/2024 8:21 AM, Bryan O'Donoghue wrote:
> On 05/12/2024 15:55, Depeng Shao wrote:
>> Add a default case in vfe_src_pad_code to get rid of a compile
>> warning if a new hw enum is added.
>>
>> Signed-off-by: Depeng Shao <quic_depengs@...cinc.com>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
>>   drivers/media/platform/qcom/camss/camss-vfe.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/ 
>> media/platform/qcom/camss/camss-vfe.c
>> index 58e24a043e81..1c9b6569fbe5 100644
>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
>> @@ -404,6 +404,10 @@ static u32 vfe_src_pad_code(struct vfe_line 
>> *line, u32 sink_code,
>>               return sink_code;
>>           }
>>           break;
>> +    default:
>> +        WARN(1, "Unsupported HW version: %x\n",
>> +             vfe->camss->res->version);
>> +        break;
>>       }
>>       return 0;
>>   }
> 
> Please re-order your patches here.
> 
> Generic fixes in a series to enable silicon are _fine_ but such fixes 
> should come before the silicon enabling portion of the series.
> 
> So this patch should come before "[PATCH 11/16] dt-bindings: media: 
> camss: Add qcom,sm8550-camss binding"
> 

Sure, will re-order the patches based on your suggestion.

Thanks,
Depeng