linux-kernel - Re: [PATCH 27/31] DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241207093308.55376e8e@foz.lan>
Date: Sat, 7 Dec 2024 09:33:08 +0100
From: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To: Markus Armbruster <armbru@...hat.com>
Cc: Ani Sinha <anisinha@...hat.com>, "Michael S . Tsirkin" <mst@...hat.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, Shiju Jose
 <shiju.jose@...wei.com>, Dongjiu Geng <gengdongjiu1@...il.com>, Igor
 Mammedov <imammedo@...hat.com>, linux-kernel@...r.kernel.org,
 qemu-arm@...gnu.org, qemu-devel@...gnu.org
Subject: Re: [PATCH 27/31] DEBUG

Em Sat, 07 Dec 2024 07:16:31 +0100
Markus Armbruster <armbru@...hat.com> escreveu:

> Ani Sinha <anisinha@...hat.com> writes:
> 
> > On Fri, Dec 6, 2024 at 10:51 PM Mauro Carvalho Chehab
> > <mchehab+huawei@...nel.org> wrote:  
> >>
> >> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> >> ---
> >>  hw/acpi/ghes.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
> >> index abca351b18de..1fe4c536611a 100644
> >> --- a/hw/acpi/ghes.c
> >> +++ b/hw/acpi/ghes.c
> >> @@ -534,9 +534,11 @@ void ghes_record_cper_errors(const void *cper, size_t len,
> >>      ags = &acpi_ged_state->ghes_state;
> >>
> >>      if (!ags->hest_lookup) {
> >> +        fprintf(stderr,"Using old GHES lookup\n");  
> >
> > I don't like this. If you must please have them under #ifdef DEBUG or
> > somesuch. See ich9.c  
> 
> Judging from the subject line, it's not meant to be posted, let alone
> merged :)

Sorry! Yea, this was not meant to be posted.

I ended submitting the entire pile of patches I have pending, including some
patches I placed at the end to test that what method is used to calculate
offsets (the one supported up to current QEMU version, which is limted,
and the new one that uses backport logic).

I'll submit the right patches again. Please ignore this.

Regards,
Mauro