linux-kernel - Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa78f27a-a92c-452d-b710-c4b3c8c52629@gmx.de>
Date: Sat, 7 Dec 2024 22:26:31 +0100
From: Armin Wolf <W_Armin@....de>
To: Povilas Kanapickas <povilas@...ix.lt>, pali@...nel.org
Cc: jdelvare@...e.com, linux@...ck-us.net, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control
 whitelist

Am 07.12.24 um 21:26 schrieb Povilas Kanapickas:

> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.

Can you check if using i8k_fan_control_data[I8K_FAN_30A3_31A3] also works?

The reason for this is that the official Dell software seems to use those SMM calls
to enable/disable automatic fan control. If this does not work then you can keep
the i8k_fan_control_data[I8K_FAN_34A3_35A3].

Thanks,
Armin Wolf

> Signed-off-by: Povilas Kanapickas <povilas@...ix.lt>
> ---
>   drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f5bdf842040e..bcb295ea3319 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
>                  },
>                  .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>          },
> +       {
> +               .ident = "Dell XPS 13 9370",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
> +               },
> +               .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> +       },
>          {
>                  .ident = "Dell Optiplex 7000",
>                  .matches = {