linux-kernel - Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0562de57-1d45-4b82-bb0e-e98ee1d6221b@radix.lt>
Date: Thu, 9 Jan 2025 23:03:23 +0200
From: Povilas Kanapickas <povilas@...ix.lt>
To: Armin Wolf <W_Armin@....de>, pali@...nel.org
Cc: jdelvare@...e.com, linux@...ck-us.net, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control
 whitelist

On 2024-12-07 23:26, Armin Wolf wrote:
> Am 07.12.24 um 21:26 schrieb Povilas Kanapickas:
> 
>> Add the Dell XPS 9370 to the fan control whitelist to allow
>> for manual fan control.
> 
> Can you check if using i8k_fan_control_data[I8K_FAN_30A3_31A3] also works?
> 
> The reason for this is that the official Dell software seems to use
> those SMM calls
> to enable/disable automatic fan control. If this does not work then you
> can keep
> the i8k_fan_control_data[I8K_FAN_34A3_35A3].

Sorry for taking this long to test. I can confirm I8K_FAN_30A3_31A3
works. I will submit a new patch.

Thanks,
Povilas

> Thanks,
> Armin Wolf
> 
>> Signed-off-by: Povilas Kanapickas <povilas@...ix.lt>
>> ---
>>   drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-
>> hwmon.c
>> index f5bdf842040e..bcb295ea3319 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id
>> i8k_whitelist_fan_control[] __initconst = {
>>                  },
>>                  .driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>>          },
>> +       {
>> +               .ident = "Dell XPS 13 9370",
>> +               .matches = {
>> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
>> +               },
>> +               .driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>> +       },
>>          {
>>                  .ident = "Dell Optiplex 7000",
>>                  .matches = {