linux-kernel - Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic mbox operations and structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241207184117.4ec188c7@kernel.org>
Date: Sat, 7 Dec 2024 18:41:17 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Sai Krishna <saikrishnag@...vell.com>
Cc: <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <sgoutham@...vell.com>, <gakula@...vell.com>, <lcherian@...vell.com>,
 <jerinj@...vell.com>, <hkelam@...vell.com>, <sbhatta@...vell.com>,
 <andrew+netdev@...n.ch>, <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic mbox
 operations and structures

On Wed, 4 Dec 2024 19:38:17 +0530 Sai Krishna wrote:
> -	ret = request_irq(pci_irq_vector(rvu->pdev, RVU_AF_INT_VEC_MBOX),
> -			  rvu_mbox_pf_intr_handler, 0,
> -			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX * NAME_SIZE], rvu);
> +	ret = request_irq(pci_irq_vector
> +			  (rvu->pdev, RVU_AF_INT_VEC_MBOX),
> +			  rvu->ng_rvu->rvu_mbox_ops->pf_intr_handler, 0,
> +			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> +			  NAME_SIZE], rvu);

You're breaking these lines in very strange way. AFAICT they fit in 
80 chars.