linux-kernel - Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic mbox operations and structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BY3PR18MB4707F24DEA004322270A5009A03C2@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Mon, 9 Dec 2024 09:26:25 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Linu Cherian <lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@...vell.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic mbox operations
 and structures

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Sunday, December 8, 2024 8:11 AM
> To: Sai Krishna Gajula <saikrishnag@...vell.com>
> Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Sunil Kovvuri Goutham
> <sgoutham@...vell.com>; Geethasowjanya Akula <gakula@...vell.com>;
> Linu Cherian <lcherian@...vell.com>; Jerin Jacob <jerinj@...vell.com>;
> Hariprasad Kelam <hkelam@...vell.com>; Subbaraya Sundeep Bhatta
> <sbhatta@...vell.com>; andrew+netdev@...n.ch; kalesh-
> anakkur.purayil@...adcom.com
> Subject: Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic
> mbox operations and structures
> 
> On Wed, 4 Dec 2024 19: 38: 17 +0530 Sai Krishna wrote: > - ret =
> request_irq(pci_irq_vector(rvu->pdev, RVU_AF_INT_VEC_MBOX), > -
> rvu_mbox_pf_intr_handler, 0, > - &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> NAME_SIZE], rvu); > + 
> On Wed, 4 Dec 2024 19:38:17 +0530 Sai Krishna wrote:
> > -	ret = request_irq(pci_irq_vector(rvu->pdev,
> RVU_AF_INT_VEC_MBOX),
> > -			  rvu_mbox_pf_intr_handler, 0,
> > -			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> NAME_SIZE], rvu);
> > +	ret = request_irq(pci_irq_vector
> > +			  (rvu->pdev, RVU_AF_INT_VEC_MBOX),
> > +			  rvu->ng_rvu->rvu_mbox_ops->pf_intr_handler, 0,
> > +			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
> > +			  NAME_SIZE], rvu);
> 
> You're breaking these lines in very strange way. AFAICT they fit in
> 80 chars.

Ack, will submit V6 patch set with the suggested changes.

Thanks,
Sai