linux-kernel - Re: [PATCH v1 1/2] driver core: Split devres APIs to device/devres.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1Y9uqGyq-yuxoEe@smile.fi.intel.com>
Date: Mon, 9 Dec 2024 02:45:46 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	Lars-Peter Clausen <lars@...afoo.de>, gregkh@...uxfoundation.org,
	"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v1 1/2] driver core: Split devres APIs to device/devres.h

On Sun, Dec 08, 2024 at 05:10:01PM +0000, Jonathan Cameron wrote:
> On Tue,  3 Dec 2024 21:48:51 +0200
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > device.h is a huge header which is hard to follow and easy to miss
> > something. Improve that by splitting devres APIs to device/devres.h.
> > 
> > In particular this helps to speedup the build of the code that includes
> > device.h solely for a devres APIs.

...

> > -#include <linux/overflow.h>
> > +
> Unrelated change.

Which one? Blank line?

...

> > -#include <linux/cleanup.h>
> This header movement is unrelated.

No problem to let it stay at the same place.

> I agree both are good but probably want to be a separate patch.
> 
> Otherwise this seems sensible to me, but your cc list seems a little short!
> 
> Greg and Rafael seems a good starting point so I've added them.

Thanks! I need to check why they were not included into the original
submission. Perhpas I need to amend MAINTAINERS,

-- 
With Best Regards,
Andy Shevchenko