linux-kernel - Re: [PATCH v2 5/6] mmc: sdhci-acpi: Tidy up ACPI ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1cdjFiv61v08CNF@smile.fi.intel.com>
Date: Mon, 9 Dec 2024 18:40:44 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
	Victor Shih <victor.shih@...esyslogic.com.tw>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/6] mmc: sdhci-acpi: Tidy up ACPI ID table

On Mon, Dec 09, 2024 at 01:29:19PM +0200, Adrian Hunter wrote:
> On 1/11/24 12:11, Andy Shevchenko wrote:
> > Tidy up ACPI ID table:
> > - sort entries alphabetically for better maintenance
> 
> Not a fan of alphabetical order just for the sake of it.

It's not for the sake of it, that makes easier to see what's going on with the
IDs. It's not the first time I stumbled over (unsorted) ID list and questioning
what the ID belongs to (vendor wise) and how many of them from the same vendor
and how many of them are invalid.

> In this case, it seems to me more useful to keep different
> vendors IDs together.

Agree, but also note, alphabetical order roughly gives the different vendor IDs
together with also grouping PNP/ACPI/invalid ACPI IDs.

-- 
With Best Regards,
Andy Shevchenko