linux-kernel - Re: [PATCH v2 6/6] mmc: sdhci-acpi: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1ceS7FksaPeqYjF@smile.fi.intel.com>
Date: Mon, 9 Dec 2024 18:43:55 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
	Victor Shih <victor.shih@...esyslogic.com.tw>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/6] mmc: sdhci-acpi: Don't use "proxy" headers

On Mon, Dec 09, 2024 at 01:32:36PM +0200, Adrian Hunter wrote:
> On 1/11/24 12:11, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use) principle.
> > While at it, sort them alphabetically for better maintenance.
> 
> Not a fan of alphabetical order for include files.
> In this case it makes it hard to see what actually
> changed.

Huh?! It will be quite easy to see if anything is being added or removed and
makes code robust against (possible) duplications. Much easier to maintain!

If you are talking about _this_ change, then it's true, but only for _this_
change, and not for the future changes. Alphabetical order is natural for
humans (and we write code for humans) which our brains are trained for. So
the processing time of the ordered data is higher and less resource-consuming.

-- 
With Best Regards,
Andy Shevchenko