| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <64332634-751c-400c-9f46-7903ec85fe03@oss.nxp.com>
Date: Mon, 9 Dec 2024 18:54:59 +0200
From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
To: Frank Li <Frank.li@....com>
Cc: Chester Lin <chester62515@...il.com>, Matthias Brugger
<mbrugger@...e.com>, Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>,
Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Pengutronix Kernel Team <kernel@...gutronix.de>,
linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
NXP S32 Linux <s32@....com>, Christophe Lizzi <clizzi@...hat.com>,
Alberto Ruiz <aruizrui@...hat.com>, Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH] arm64: dts: s32g: add I2C support
On 12/6/2024 7:12 PM, Frank Li wrote:
> On Fri, Dec 06, 2024 at 02:31:19PM +0200, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>>
>> Add the I2C Devicetree nodes and pinmux for S32G2 and S32G3 SoCs.
>>
>> With respect to S32G2/S32G3 SoC based boards, there are multiple RDB
>> (rdb2 vs rdb3) and EVB (for G2 vs for G3) board revisions. These versions
>> are quite similar. The common part for the EVB revisions will be
>> centralized in 's32gxxa-evb.dtsi' file, while the RDB commonalities will
>> be placed in 's32gxxa-rdb.dtsi' file.
>>
>> This refactor will also serve for other modules in the future, such as
>> FlexCAN, DSPI.
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/s32g2.dtsi | 45 ++++++
>> .../arm64/boot/dts/freescale/s32g274a-evb.dts | 1 +
>> .../boot/dts/freescale/s32g274a-rdb2.dts | 1 +
>> arch/arm64/boot/dts/freescale/s32g3.dtsi | 50 ++++++
>> .../boot/dts/freescale/s32g399a-rdb3.dts | 12 ++
>> .../boot/dts/freescale/s32gxxxa-evb.dtsi | 150 ++++++++++++++++++
>> .../boot/dts/freescale/s32gxxxa-rdb.dtsi | 124 +++++++++++++++
>> 7 files changed, 383 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/freescale/s32gxxxa-evb.dtsi
>> create mode 100644 arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi
>> index 7be430b78c83..0e6c847ab0c3 100644
>> --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi
>> @@ -333,6 +333,33 @@ uart1: serial@...cc000 {
>> status = "disabled";
>> };
>>
>> + i2c0: i2c@...e4000 {
>> + compatible = "nxp,s32g2-i2c";
>> + reg = <0x401e4000 0x1000>;
>> + interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>
> hardcode 40? can you use macro for clock index? Many place use it.
>
> Frank
>
Hello Frank,
Thank you for your review on this patch.
A discussion regarding clock indexes for S32G SoC Modules has already
taken place on the mailing list [1]. The conclusion was to directly use
the clock index numbers.
[1]
https://lore.kernel.org/all/f54d947c-58dc-498f-8871-b472f97be4a8@oss.nxp.com/
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@...e8000 {
>> + compatible = "nxp,s32g2-i2c";
>> + reg = <0x401e8000 0x1000>;
>> + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@...ec000 {
>> + compatible = "nxp,s32g2-i2c";
>> + reg = <0x401ec000 0x1000>;
>> + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> uart2: serial@...bc000 {
>> compatible = "nxp,s32g2-linflexuart",
>> "fsl,s32v234-linflexuart";
>> @@ -341,6 +368,24 @@ uart2: serial@...bc000 {
>> status = "disabled";
>> };
>>
>> + i2c3: i2c@...d8000 {
>> + compatible = "nxp,s32g2-i2c";
>> + reg = <0x402d8000 0x1000>;
>> + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> + i2c4: i2c@...dc000 {
>> + compatible = "nxp,s32g2-i2c";
>> + reg = <0x402dc000 0x1000>;
>> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> usdhc0: mmc@...f0000 {
>> compatible = "nxp,s32g2-usdhc";
>> reg = <0x402f0000 0x1000>;
>> diff --git a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts
>> index b9a119eea2b7..c4a195dd67bf 100644
>> --- a/arch/arm64/boot/dts/freescale/s32g274a-evb.dts
>> +++ b/arch/arm64/boot/dts/freescale/s32g274a-evb.dts
>> @@ -7,6 +7,7 @@
>> /dts-v1/;
>>
>> #include "s32g2.dtsi"
>> +#include "s32gxxxa-evb.dtsi"
>>
>> / {
>> model = "NXP S32G2 Evaluation Board (S32G-VNP-EVB)";
>> diff --git a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts
>> index aaa61a8ad0da..b5ba51696f43 100644
>> --- a/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts
>> +++ b/arch/arm64/boot/dts/freescale/s32g274a-rdb2.dts
>> @@ -7,6 +7,7 @@
>> /dts-v1/;
>>
>> #include "s32g2.dtsi"
>> +#include "s32gxxxa-rdb.dtsi"
>>
>> / {
>> model = "NXP S32G2 Reference Design Board 2 (S32G-VNP-RDB2)";
>> diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi
>> index 6c572ffe37ca..666e4029e588 100644
>> --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
>> @@ -390,6 +390,36 @@ uart1: serial@...cc000 {
>> status = "disabled";
>> };
>>
>> + i2c0: i2c@...e4000 {
>> + compatible = "nxp,s32g3-i2c",
>> + "nxp,s32g2-i2c";
>> + reg = <0x401e4000 0x1000>;
>> + interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@...e8000 {
>> + compatible = "nxp,s32g3-i2c",
>> + "nxp,s32g2-i2c";
>> + reg = <0x401e8000 0x1000>;
>> + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@...ec000 {
>> + compatible = "nxp,s32g3-i2c",
>> + "nxp,s32g2-i2c";
>> + reg = <0x401ec000 0x1000>;
>> + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> uart2: serial@...bc000 {
>> compatible = "nxp,s32g3-linflexuart",
>> "fsl,s32v234-linflexuart";
>> @@ -398,6 +428,26 @@ uart2: serial@...bc000 {
>> status = "disabled";
>> };
>>
>> + i2c3: i2c@...d8000 {
>> + compatible = "nxp,s32g3-i2c",
>> + "nxp,s32g2-i2c";
>> + reg = <0x402d8000 0x1000>;
>> + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> + i2c4: i2c@...dc000 {
>> + compatible = "nxp,s32g3-i2c",
>> + "nxp,s32g2-i2c";
>> + reg = <0x402dc000 0x1000>;
>> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&clks 40>;
>> + clock-names = "ipg";
>> + status = "disabled";
>> + };
>> +
>> usdhc0: mmc@...f0000 {
>> compatible = "nxp,s32g3-usdhc",
>> "nxp,s32g2-usdhc";
>> diff --git a/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts b/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
>> index 828e353455b5..eb73a5dcebe7 100644
>> --- a/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
>> +++ b/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
>> @@ -8,6 +8,7 @@
>> /dts-v1/;
>>
>> #include "s32g3.dtsi"
>> +#include "s32gxxxa-rdb.dtsi"
>>
>> / {
>> model = "NXP S32G3 Reference Design Board 3 (S32G-VNP-RDB3)";
>> @@ -39,6 +40,17 @@ &uart1 {
>> status = "okay";
>> };
>>
>> +&i2c4 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + ina231@40 {
>> + compatible = "ti,ina231";
>> + reg = <0x40>;
>> + shunt-resistor = <1000>;
>> + };
>> +};
>> +
>> &usdhc0 {
>> pinctrl-names = "default", "state_100mhz", "state_200mhz";
>> pinctrl-0 = <&pinctrl_usdhc0>;
>> diff --git a/arch/arm64/boot/dts/freescale/s32gxxxa-evb.dtsi b/arch/arm64/boot/dts/freescale/s32gxxxa-evb.dtsi
>> new file mode 100644
>> index 000000000000..a44eff28073a
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/s32gxxxa-evb.dtsi
>> @@ -0,0 +1,150 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
>> +/*
>> + * Copyright 2024 NXP
>> + *
>> + * Authors: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>> + * Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>
>> + * Larisa Grigore <larisa.grigore@....com>
>> + */
>> +
>> +&pinctrl {
>> + i2c0_pins: i2c0-pins {
>> + i2c0-grp0 {
>> + pinmux = <0x101>, <0x111>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c0-grp1 {
>> + pinmux = <0x2352>, <0x2362>;
>> + };
>> + };
>> +
>> + i2c0_gpio_pins: i2c0-gpio-pins {
>> + i2c0-gpio-grp0 {
>> + pinmux = <0x100>, <0x110>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c0-gpio-grp1 {
>> + pinmux = <0x2350>, <0x2360>;
>> + };
>> + };
>> +
>> + i2c1_pins: i2c1-pins {
>> + i2c1-grp0 {
>> + pinmux = <0x131>, <0x141>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c1-grp1 {
>> + pinmux = <0x2cd2>, <0x2ce2>;
>> + };
>> + };
>> +
>> + i2c1_gpio_pins: i2c1-gpio-pins {
>> + i2c1-gpio-grp0 {
>> + pinmux = <0x130>, <0x140>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c1-gpio-grp1 {
>> + pinmux = <0x2cd0>, <0x2ce0>;
>> + };
>> + };
>> +
>> + i2c2_pins: i2c2-pins {
>> + i2c2-grp0 {
>> + pinmux = <0x151>, <0x161>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c2-grp1 {
>> + pinmux = <0x2cf2>, <0x2d02>;
>> + };
>> + };
>> +
>> + i2c2_gpio_pins: i2c2-gpio-pins {
>> + i2c2-gpio-grp0 {
>> + pinmux = <0x150>, <0x160>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c2-gpio-grp1 {
>> + pinmux = <0x2cf0>, <0x2d00>;
>> + };
>> + };
>> +
>> + i2c4_pins: i2c4-pins {
>> + i2c4-grp0 {
>> + pinmux = <0x211>, <0x222>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c4-grp1 {
>> + pinmux = <0x2d43>, <0x2d33>;
>> + };
>> + };
>> +
>> + i2c4_gpio_pins: i2c4-gpio-pins {
>> + i2c4-gpio-grp0 {
>> + pinmux = <0x210>, <0x220>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c4-gpio-grp1 {
>> + pinmux = <0x2d40>, <0x2d30>;
>> + };
>> + };
>> +};
>> +
>> +&i2c0 {
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c0_pins>;
>> + pinctrl-1 = <&i2c0_gpio_pins>;
>> + status = "okay";
>> +};
>> +
>> +&i2c1 {
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c1_pins>;
>> + pinctrl-1 = <&i2c1_gpio_pins>;
>> + status = "okay";
>> +};
>> +
>> +&i2c2 {
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c2_pins>;
>> + pinctrl-1 = <&i2c2_gpio_pins>;
>> + status = "okay";
>> +};
>> +
>> +&i2c4 {
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c4_pins>;
>> + pinctrl-1 = <&i2c4_gpio_pins>;
>> + status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> new file mode 100644
>> index 000000000000..d992c0c9e695
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/freescale/s32gxxxa-rdb.dtsi
>> @@ -0,0 +1,124 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
>> +/*
>> + * Copyright 2024 NXP
>> + *
>> + * Authors: Ciprian Marian Costea <ciprianmarian.costea@....nxp.com>
>> + * Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>
>> + * Larisa Grigore <larisa.grigore@....com>
>> + */
>> +
>> +&pinctrl {
>> + i2c0_pins: i2c0-pins {
>> + i2c0-grp0 {
>> + pinmux = <0x1f2>, <0x201>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c0-grp1 {
>> + pinmux = <0x2353>, <0x2363>;
>> + };
>> + };
>> +
>> + i2c0_gpio_pins: i2c0-gpio-pins {
>> + i2c0-gpio-grp0 {
>> + pinmux = <0x1f0>, <0x200>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c0-gpio-grp1 {
>> + pinmux = <0x2350>, <0x2360>;
>> + };
>> + };
>> +
>> + i2c2_pins: i2c2-pins {
>> + i2c2-grp0 {
>> + pinmux = <0x151>, <0x161>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c2-grp1 {
>> + pinmux = <0x2cf2>, <0x2d02>;
>> + };
>> + };
>> +
>> + i2c2_gpio_pins: i2c2-gpio-pins {
>> + i2c2-gpio-grp0 {
>> + pinmux = <0x2cf0>, <0x2d00>;
>> + };
>> +
>> + i2c2-gpio-grp1 {
>> + pinmux = <0x150>, <0x160>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> + };
>> +
>> + i2c4_pins: i2c4-pins {
>> + i2c4-grp0 {
>> + pinmux = <0x211>, <0x222>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c4-grp1 {
>> + pinmux = <0x2d43>, <0x2d33>;
>> + };
>> + };
>> +
>> + i2c4_gpio_pins: i2c4-gpio-pins {
>> + i2c4-gpio-grp0 {
>> + pinmux = <0x210>, <0x220>;
>> + drive-open-drain;
>> + output-enable;
>> + input-enable;
>> + slew-rate = <133>;
>> + };
>> +
>> + i2c4-gpio-grp1 {
>> + pinmux = <0x2d40>, <0x2d30>;
>> + };
>> + };
>> +};
>> +
>> +&i2c0 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> #address-cells and size-cells should be common dts to avoid set it in
> board file.
>
> Other i2c2\i2c4 have not it. I suppose you can remove it here.
>
> Frank
>
Correct. I will move those in the associated 's32gxxxa-rdb.dtsi' file.
Best Regards,
Ciprian
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c0_pins>;
>> + pinctrl-1 = <&i2c0_gpio_pins>;
>> + status = "okay";
>> +
>> + pcal6524: gpio-expander@22 {
>> + compatible = "nxp,pcal6524";
>> + reg = <0x22>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + };
>> +};
>> +
>> +&i2c2 {
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c2_pins>;
>> + pinctrl-1 = <&i2c2_gpio_pins>;
>> + status = "okay";
>> +};
>> +
>> +&i2c4 {
>> + pinctrl-names = "default", "gpio";
>> + pinctrl-0 = <&i2c4_pins>;
>> + pinctrl-1 = <&i2c4_gpio_pins>;
>> + status = "okay";
>> +};
>> --
>> 2.45.2
>>
Powered by blists - more mailing lists