linux-kernel - Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z1chC8GHeog24M33@smile.fi.intel.com>
Date: Mon, 9 Dec 2024 18:55:39 +0200
From: Andy Shevchenko <andy@...nel.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Paul Burton <paulburton@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct
 img_ascii_lcd_config

On Mon, Dec 09, 2024 at 09:55:48AM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 6, 2024 at 11:26 PM Christophe JAILLET
> <christophe.jaillet@...adoo.fr> wrote:
> > 'struct img_ascii_lcd_config' is not modified in this driver.
> >
> > Constifying this structure moves some data to a read-only section, so
> > increase overall security, especially when the structure holds some
> > function pointers.
> >
> > On a x86_64, with allmodconfig:
> > Before:
> > ======
> >    text    data     bss     dec     hex filename
> >    6110     728       0    6838    1ab6 drivers/auxdisplay/img-ascii-lcd.o
> >
> > After:
> > =====
> >    text    data     bss     dec     hex filename
> >    6198     632       0    6830    1aae drivers/auxdisplay/img-ascii-lcd.o
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko