linux-kernel - Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVaJyW3bvTxRfcDavA9HaukUDGBaTWRoUtrwjy_rb2DpA@mail.gmail.com>
Date: Mon, 9 Dec 2024 09:55:48 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Paul Burton <paulburton@...nel.org>, Andy Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd_config

On Fri, Dec 6, 2024 at 11:26 PM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
> 'struct img_ascii_lcd_config' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text    data     bss     dec     hex filename
>    6110     728       0    6838    1ab6 drivers/auxdisplay/img-ascii-lcd.o
>
> After:
> =====
>    text    data     bss     dec     hex filename
>    6198     632       0    6830    1aae drivers/auxdisplay/img-ascii-lcd.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds