linux-kernel - Re: [EXTERNAL] [PATCH] x86: Fix build regression with CONFIG_KEXEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b8f82c0c38093f0092f1015b641c30f2f478e17.camel@infradead.org>
Date: Mon, 09 Dec 2024 17:07:06 +0000
From: David Woodhouse <dwmw2@...radead.org>
To: Borislav Petkov <bp@...en8.de>
Cc: Damien Le Moal <dlemoal@...nel.org>, Linus Torvalds
	 <torvalds@...ux-foundation.org>, Ingo Molnar <mingo@...nel.org>, Thomas
 Gleixner <tglx@...utronix.de>, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [EXTERNAL] [PATCH] x86: Fix build regression with
 CONFIG_KEXEC_JUMP enabled

On Mon, 2024-12-09 at 17:22 +0100, Borislav Petkov wrote:
> On Mon, Dec 09, 2024 at 03:59:55PM +0000, David Woodhouse wrote:
> > (In fact, *lots* of the return path from kexec is just unreachable dead
> > code in the case that CONFIG_KEXEC_JUMP isn't set, but it seems we're
> > in the habit of #ifdeffing out only the parts that actually wouldn't
> > compile.)
> 
> Yeah, we're allergic to ugly ifdeffery.

I suspect it would be less ugly overall if we #ifdef out the whole of
the preserve_context code path when CONFIG_KEXEC_JUMP isn't enabled,
rather than only the various parts of it that actually cause compile
failures, leaving a very confusing set of nonsense dead code actually
being compiled in. But that's a potential cleanup for later; I'm
standing in a massive pile of yak hair already...

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)