linux-kernel - Re: [EXTERNAL] [PATCH] x86: Fix build regression with CONFIG_KEXEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241209171818.GGZ1cmWjBZJJE-mg-o@fat_crate.local>
Date: Mon, 9 Dec 2024 18:18:18 +0100
From: Borislav Petkov <bp@...en8.de>
To: David Woodhouse <dwmw2@...radead.org>
Cc: Damien Le Moal <dlemoal@...nel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [EXTERNAL] [PATCH] x86: Fix build regression with
 CONFIG_KEXEC_JUMP enabled

On Mon, Dec 09, 2024 at 05:07:06PM +0000, David Woodhouse wrote:
> I suspect it would be less ugly overall if we #ifdef out the whole of
> the preserve_context code path when CONFIG_KEXEC_JUMP isn't enabled,
> rather than only the various parts of it that actually cause compile
> failures, leaving a very confusing set of nonsense dead code actually
> being compiled in.

$ git grep CONFIG_KEXEC_JUMP *.[chS] | wc -l
10

That's mostly C code. You want to push the ifdeffery into the asm?

> But that's a potential cleanup for later; I'm standing in a massive pile of
> yak hair already...

You too?! I can't see you from all yak hair around me ... :-P

But yeah, one fine day...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette