linux-kernel - Re: linux-next: Fixes tag needs some work in the bpf-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKrU3d8dt9SFLM_0wLAjQBfhU=utENF5gYtLCMds_f7uw@mail.gmail.com>
Date: Mon, 9 Dec 2024 09:18:51 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Daniel Borkmann <daniel@...earbox.net>, Alexei Starovoitov <ast@...nel.org>, 
	Andrii Nakryiko <andrii@...nel.org>, 
	Alexis Lothoré (eBPF Foundation) <alexis.lothore@...tlin.com>, 
	bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the bpf-next tree

On Sun, Dec 8, 2024 at 11:16 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   c721d8f8b196 ("selftests/bpf: ensure proper root namespace cleanup when test fail")
>
> Fixes tag
>
>   Fixes: 284ed00a59dd ("selftests/bpf: migrate flow_dissector namespace exclusivity test")
>
> has these problem(s):
>
>   - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 6fb5be12d1bb ("selftests/bpf: migrate flow_dissector namespace exclusivity test")

I believe the fixes tag was correct when it was first applied
during merge window (without being in for-next),
but then bpf-next/master was rebased after rc1 was released
and fixes tag became wrong.
Now the commit c721d8f8b196 is so far down that we cannot fix it and
force push it. We don't rebase after rc1 either.
Sadly it would have to stay this way.
We probably need to run our pw-check [0] script during the rebase
to make sure such mistakes don't happen.

[0]
https://git.kernel.org/pub/scm/linux/kernel/git/dborkman/pw.git/tree/pw-check