linux-kernel - Re: [PATCH net-next 2/2] net: phy: microchip_t1: Autonegotiaion support for LAN887x T1 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d230d3c-740b-4876-a0f7-e48361b6d238@lunn.ch>
Date: Mon, 9 Dec 2024 18:11:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Tarun Alle <Tarun.Alle@...rochip.com>
Cc: arun.ramadoss@...rochip.com, UNGLinuxDriver@...rochip.com,
	hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: microchip_t1: Autonegotiaion
 support for LAN887x T1 phy

> -	/* First patch only supports 100Mbps and 1000Mbps force-mode.
> -	 * T1 Auto-Negotiation (Clause 98 of IEEE 802.3) will be added later.
> -	 */
> -	linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported);
> -

What are the backwards compatibility issues here? I would at least
expect some comments in the commit message. As far as i understand, up
until this patch, it always required forced configuration. With this
patch, it suddenly will auto-neg by default? If the link partner is
not expecting auto-neg, that will fail.

> +/* LAN887X Errata: 100M master issue. Dual speed in Aneg is not supported. */

Please could you expand on this. We are now doing auto-neg by default,
and auto-neg is somewhat broken?

	Andrew