linux-kernel - RE: [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion changes for T1 phy in phy library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DM4PR11MB6239E2433E6802AE9EC6E6B08B3D2@DM4PR11MB6239.namprd11.prod.outlook.com>
Date: Tue, 10 Dec 2024 06:39:10 +0000
From: <Tarun.Alle@...rochip.com>
To: <andrew@...n.ch>
CC: <Arun.Ramadoss@...rochip.com>, <UNGLinuxDriver@...rochip.com>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion changes
 for T1 phy in phy library

Hi Andrew,

Thanks for your review comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, December 9, 2024 10:24 PM
> To: Tarun Alle - I68638 <Tarun.Alle@...rochip.com>
> Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@...rochip.com>;
> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>;
> hkallweit1@...il.com; linux@...linux.org.uk; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next 1/2] net: phy: phy-c45: Auto-negotiaion
> changes for T1 phy in phy library
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
> 
> On Mon, Dec 09, 2024 at 09:44:26PM +0530, Tarun Alle wrote:
> > Below auto-negotiation library changes required for T1 phys:
> > - Lower byte advertisement register need to read after higher byte as
> >   per 802.3-2022 : Section 45.2.7.22.
> 
> Is this a fix? Does Linux have any T1 PHYs which already support auto-neg?
> Either add a comment this is not a fix because...., or please pull this out into
> a patch for net, with a Fixes: tag.
> 

There are few implementations for T1 PHY auto-neg. I will pull this out as a fix.

>         Andrew

Thanks,
Tarun Alle.