linux-kernel - Re: [PATCH net v2] net: ethernet: 8390: Add HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd1fb2205d974ee320ddb648c0589940e8646a6c.camel@linux.ibm.com>
Date: Mon, 09 Dec 2024 18:12:44 +0100
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
 <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc: Arnd Bergmann <arnd@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net v2] net: ethernet: 8390: Add HAS_IOPORT dependency
 for mcf8390

On Mon, 2024-12-09 at 12:26 +0100, Niklas Schnelle wrote:
> Since commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
> for HAS_IOPORT=n") the I/O port accessors are compile-time optional. As
> m68k may or may not select HAS_IOPORT the COLDFIRE dependency is not
> enough to guarantee I/O port access. Add an explicit HAS_IOPORT
> dependency for mcf8390 to prevent a build failure as seen by the kernel
> test robot.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412080511.ORVinTDs-lkp@intel.com/
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> ---
> Changes in v2:
> - Add missing "net" prefix. Sorry about the noise
> - Link to v1: https://lore.kernel.org/r/20241209-mcf8390_has_ioport-v1-1-f263d573e243@linux.ibm.com

See Arnd's answer[0] to v1 for why this patch may be fixing the compile
error but the code may already be broken independently.

[0]
https://lore.kernel.org/all/3ca55478-a5a9-442b-ae4f-a0a822f786d9@app.fastmail.com/