linux-kernel - [PATCH net v2] net: ethernet: 8390: Add HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241209-mcf8390_has_ioport-v2-1-3254267dc35e@linux.ibm.com>
Date: Mon, 09 Dec 2024 12:26:50 +0100
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc: Arnd Bergmann <arnd@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>
Subject: [PATCH net v2] net: ethernet: 8390: Add HAS_IOPORT dependency for
 mcf8390

Since commit 6f043e757445 ("asm-generic/io.h: Remove I/O port accessors
for HAS_IOPORT=n") the I/O port accessors are compile-time optional. As
m68k may or may not select HAS_IOPORT the COLDFIRE dependency is not
enough to guarantee I/O port access. Add an explicit HAS_IOPORT
dependency for mcf8390 to prevent a build failure as seen by the kernel
test robot.

Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412080511.ORVinTDs-lkp@intel.com/
Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
---
Changes in v2:
- Add missing "net" prefix. Sorry about the noise
- Link to v1: https://lore.kernel.org/r/20241209-mcf8390_has_ioport-v1-1-f263d573e243@linux.ibm.com
---
 drivers/net/ethernet/8390/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/8390/Kconfig b/drivers/net/ethernet/8390/Kconfig
index 345f250781c6d9c3c6cbe5445250dc5987803b1a..f2ee99532187d133fdb02bc4b82c7fc4861f90af 100644
--- a/drivers/net/ethernet/8390/Kconfig
+++ b/drivers/net/ethernet/8390/Kconfig
@@ -87,7 +87,7 @@ config MAC8390
 
 config MCF8390
 	tristate "ColdFire NS8390 based Ethernet support"
-	depends on COLDFIRE
+	depends on COLDFIRE && HAS_IOPORT
 	select CRC32
 	help
 	  This driver is for Ethernet devices using an NS8390-compatible

---
base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4
change-id: 20241209-mcf8390_has_ioport-7dcb85a5170c

Best regards,
-- 
Niklas Schnelle