linux-kernel - Re: [PATCH RESEND v1 1/2] mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6d8af9c-f4e9-46b3-9e0b-f780a0ef52ac@suse.cz>
Date: Mon, 9 Dec 2024 18:45:29 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org
Cc: linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
 Oscar Salvador <osalvador@...e.de>, Zi Yan <ziy@...dia.com>
Subject: Re: [PATCH RESEND v1 1/2] mm/page_alloc: don't use __GFP_HARDWALL
 when migrating pages via alloc_contig*()

On 12/5/24 10:05, David Hildenbrand wrote:
> We'll migrate pages allocated by other contexts; respecting the cpuset of
> the alloc_contig*() caller when allocating a migration target does not
> make sense.
> 
> Drop the __GFP_HARDWALL.
> 
> Note that in an ideal world, migration code could figure out the cpuset
> of the original context and take that into consideration.
> 
> Suggested-by: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>  mm/page_alloc.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48a291c485df..acadfcf654fd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6410,11 +6410,11 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp_mask, gfp_t *gfp_cc_mask)
>  	 * page range. Migratable pages are movable, __GFP_MOVABLE is implied
>  	 * for them.
>  	 *
> -	 * Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set,
> -	 * keep doing that to not degrade callers.
> +	 * Traditionally we always had __GFP_RETRY_MAYFAIL set, keep doing that
> +	 * to not degrade callers.
>  	 */
>  	*gfp_cc_mask = (gfp_mask & (reclaim_mask | cc_action_mask)) |
> -			__GFP_HARDWALL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
> +			__GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
>  	return 0;
>  }
>