linux-kernel - Re: [PATCH net-next v13 07/22] ovpn: implement basic TX path (UDP)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202412081739.56GeY9xL-lkp@intel.com>
Date: Mon, 9 Dec 2024 12:45:15 +0800
From: kernel test robot <lkp@...el.com>
To: Antonio Quartulli <antonio@...nvpn.net>, netdev@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Donald Hunter <donald.hunter@...il.com>,
	Shuah Khan <skhan@...uxfoundation.org>, sd@...asysnail.net,
	ryazanov.s.a@...il.com, Andrew Lunn <andrew+netdev@...n.ch>
Cc: oe-kbuild-all@...ts.linux.dev, Simon Horman <horms@...nel.org>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v13 07/22] ovpn: implement basic TX path (UDP)

Hi Antonio,

kernel test robot noticed the following build errors:

[auto build test ERROR on 152d00a913969514967ad3f962b3b1c8983eb2d7]

url:    https://github.com/intel-lab-lkp/linux/commits/Antonio-Quartulli/net-introduce-OpenVPN-Data-Channel-Offload-ovpn/20241207-054712
base:   152d00a913969514967ad3f962b3b1c8983eb2d7
patch link:    https://lore.kernel.org/r/20241206-b4-ovpn-v13-7-67fb4be666e2%40openvpn.net
patch subject: [PATCH net-next v13 07/22] ovpn: implement basic TX path (UDP)
config: nios2-randconfig-r131-20241208 (https://download.01.org/0day-ci/archive/20241208/202412081739.56GeY9xL-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20241208/202412081739.56GeY9xL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412081739.56GeY9xL-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/net/ovpn/io.c:18:
   drivers/net/ovpn/skb.h: In function 'ovpn_ip_check_protocol':
>> drivers/net/ovpn/skb.h:46:56: error: invalid application of 'sizeof' to incomplete type 'struct ipv6hdr'
      46 |                 if (!pskb_network_may_pull(skb, sizeof(struct ipv6hdr)))
         |                                                        ^~~~~~


vim +46 drivers/net/ovpn/skb.h

    29	
    30	/* Return IP protocol version from skb header.
    31	 * Return 0 if protocol is not IPv4/IPv6 or cannot be read.
    32	 */
    33	static inline __be16 ovpn_ip_check_protocol(struct sk_buff *skb)
    34	{
    35		__be16 proto = 0;
    36	
    37		/* skb could be non-linear,
    38		 * make sure IP header is in non-fragmented part
    39		 */
    40		if (!pskb_network_may_pull(skb, sizeof(struct iphdr)))
    41			return 0;
    42	
    43		if (ip_hdr(skb)->version == 4) {
    44			proto = htons(ETH_P_IP);
    45		} else if (ip_hdr(skb)->version == 6) {
  > 46			if (!pskb_network_may_pull(skb, sizeof(struct ipv6hdr)))
    47				return 0;
    48			proto = htons(ETH_P_IPV6);
    49		}
    50	
    51		return proto;
    52	}
    53	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki