linux-kernel - Re: [PATCH v2] zonefs: Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e8f3f35-a80a-4505-b82d-9ac3f4a90785@kernel.org>
Date: Mon, 9 Dec 2024 13:47:18 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] zonefs: Fix the wrong format specifier

On 12/9/24 11:52, Zhu Jun wrote:
> Change f to unsigned int to resolve the mismatch in format specifiers for
> snprintf(), where %u should be used for unsigned integers instead of %d
> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>

The patch title is now wrong... And you forgot to add a Fixes tag.
Will fix that when applying. Thanks.

> ---
> Changes:
> v2:
> A better fix is to make f "unsigned int" as that is consistent with
> g_nr_zones and the fact that up to "unsigned int" total number of zones are
> allowed for a zoned device.
> 
> Can you send a v2 ? Also please add a Fixes tag.
> 
>  fs/zonefs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index faf1eb878..695da258a 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -791,7 +791,7 @@ static int zonefs_readdir_zgroup(struct file *file,
>  	int fname_len;
>  	char *fname;
>  	ino_t ino;
> -	int f;
> +	unsigned int f;
>  
>  	/*
>  	 * The size of zone group directories is equal to the number


-- 
Damien Le Moal
Western Digital Research