linux-kernel - Re: [PATCH] cxgb4: prevent potential integer overflow on 32bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241209185556.GA2367494@nvidia.com>
Date: Mon, 9 Dec 2024 14:55:56 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Atul Gupta <atul.gupta@...lsio.com>,
	Potnuri Bharat Teja <bharat@...lsio.com>,
	Leon Romanovsky <leon@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Casey Leedom <leedom@...lsio.com>,
	Michael Werner <werner@...lsio.com>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] cxgb4: prevent potential integer overflow on 32bit

On Sat, Nov 30, 2024 at 01:01:37PM +0300, Dan Carpenter wrote:
> The "gl->tot_len" variable is controlled by the user.  It comes from
> process_responses().  On 32bit systems, the "gl->tot_len +
> sizeof(struct cpl_pass_accept_req) + sizeof(struct rss_header)" addition
> could have an integer wrapping bug.  Use size_add() to prevent this.
> 
> Fixes: a08943947873 ("crypto: chtls - Register chtls with net tls")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
> This is from static analysis.  I've spent some time reviewing this code
> but I might be wrong.

Applied to for-next

I fixed the Fixes line:

    Fixes: 1cab775c3e75 ("RDMA/cxgb4: Fix LE hash collision bug for passive open connection")

Thanks,
Jason