linux-kernel - Re: [PATCH v3 3/3] arm64: dts: qcom: qcs615-ride: Enable UFS node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66654b75-cfc2-470c-90e9-76da5e2a1f47@quicinc.com>
Date: Mon, 9 Dec 2024 16:31:34 +0800
From: Xin Liu <quic_liuxin@...cinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        "Kishon Vijay Abraham I" <kishon@...nel.org>,
        Alim Akhtar
	<alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        Bart Van Assche
	<bvanassche@....org>,
        "Andy Gross" <agross@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <quic_jiegan@...cinc.com>, <quic_aiquny@...cinc.com>,
        <quic_tingweiz@...cinc.com>, <quic_sayalil@...cinc.com>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: qcom: qcs615-ride: Enable UFS node



在 2024/12/2 22:48, Manivannan Sadhasivam 写道:
> On Fri, Nov 22, 2024 at 02:44:28PM +0800, Xin Liu wrote:
>> From: Sayali Lokhande <quic_sayalil@...cinc.com>
>>
>> Enable UFS on the Qualcomm QCS615 Ride platform.
>>
>> Signed-off-by: Sayali Lokhande <quic_sayalil@...cinc.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>> Co-developed-by: Xin Liu <quic_liuxin@...cinc.com>
>> Signed-off-by: Xin Liu <quic_liuxin@...cinc.com>
> 
> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> One question below.
> 
>> ---
>>   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> index ee6cab3924a6..79634646350b 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
>> @@ -214,6 +214,22 @@ &uart0 {
>>   	status = "okay";
>>   };
>>   
>> +&ufs_mem_hc {
> 
> No 'reset-gpios' to reset the UFS device?
I will check it, and fix it next version.
> 
> - Mani
>