linux-kernel - Re: [PATCH PATCH RFT 11/19] arm64: dts: qcom: sm8650: Fix CDSP memory length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e2013c8-e11f-47b1-a28f-960b2aed72e5@linaro.org>
Date: Mon, 9 Dec 2024 11:51:34 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: neil.armstrong@...aro.org, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Abel Vesa <abel.vesa@...aro.org>, Sibi Sankar <quic_sibis@...cinc.com>,
 Luca Weiss <luca.weiss@...rphone.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH PATCH RFT 11/19] arm64: dts: qcom: sm8650: Fix CDSP memory
 length

On 06/12/2024 16:42, Neil Armstrong wrote:
> On 06/12/2024 16:32, Krzysztof Kozlowski wrote:
>> The address space in CDSP PAS (Peripheral Authentication Service)
>> remoteproc node should point to the QDSP PUB address space
>> (QDSP6...SS_PUB) which has a length of 0x10000.  Value of 0x1400000 was
>> copied from older DTS, but it does not look accurate at all.
>>
>> This should have no functional impact on Linux users, because PAS loader
>> does not use this address space at all.
>>
>> Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes")
>> Cc: <stable@...r.kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> index 95ec82bce3162bce4a3da6122a41fee37118740e..1d935bcdcb2eee7b56e0a1f71c303a54d870e672 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>> @@ -5481,7 +5481,7 @@ nsp_noc: interconnect@...c0000 {
>>   
>>   		remoteproc_cdsp: remoteproc@...00000 {
>>   			compatible = "qcom,sm8650-cdsp-pas";
>> -			reg = <0 0x32300000 0 0x1400000>;
>> +			reg = <0x0 0x32300000 0x0 0x10000>;
> 
> I tried to have an unified style in sm8650.dtsi by using 0 instead of 0x0,
> maybe you should keep the current style, as you prefer.

I got comment for sm8750 that preferred is 0x0, so above while touching
this. Also file already has inconsistencies - 0x0 mixed with 0.



Best regards,
Krzysztof